1757931 - Grabbing the PiP by the edges in a Linux + Wayland environment, will not allow enlargement, only shrinking

Status: RESOLVED DUPLICATE of bug 1739622

(Toolkit :: Picture-in-Picture, defect, P3)

Description

[Daniel Bodea [:danibodea]]

Note

• When the user loads a video in a Linux + Wayland environment, lunches in PiP and grabs any edge, he will notice that a blank PiP window WILL NOT enlarge, only shrink.

Affected versions

• Nightly v99.0a1
• ESR v91.6.0esr

Affected platforms

• Ubuntu 21 + Wayland
• This issue does not occur on a Ubuntu 21 + xwayland

Steps to reproduce

1. Launch browser.
2. Load a video
3. Click the PiP button
4. Grab any of the edges and attempt to enlarge the PiP window.

Expected result

• The PiP window should enlarge.

Actual result

• The PiP window WILL NOT enlarge.

Regression range

• Not a recent regression.

Additional notes
*

Comment 1

[Emilio Cobos Álvarez (:emilio)]

I can try to repro this but that's a bit surprising since I'm pretty sure i can shrink and grow the PiP window just fine on fedora at least.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Err sorry that was meant for me

Comment 3

[Emilio Cobos Álvarez (:emilio)]

I couldn't repro this in neither Fedora nor Ubuntu 21, can you try to see if it's a regression or something, or if there's something else that might be needed to reproduce this? Thanks.

Comment 4

[Daniel Bodea [:danibodea]]

You should make sure Ubuntu 20/21/22 is updated to the latest version. It should install the "Wayland" Window Protocol by default.
Furthermore, Nightly is now set to open in Wayland Window Protocol by default, as well.

For the issue to reproduce, you'd have to make sure that the value of the "Window Protocol" attribute from "about:support" is "wayland" and not "x11", "xwayland" or others.

To force open the browser is Wayland Window Protocol, you can take these steps:

1. Open a terminal window inside the browser folder.
2. type "export MOZ_ENABLE_WAYLAND=1"
3. then type "./firefox"
   The browser should open in Wayland Window Protocol.

P.S. The issue still reproduces in the latest Nightly.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

I know how to get wayland enabled (I use wayland regularly) but still I can't reproduce?

Dani, can you try to see if this is a regression on your machine or so?

Comment 6

[Daniel Bodea [:danibodea]]

Attachment: about:support information of an affected system

This issue occurs on all channels (as previously mentioned). Upon attempting to bring more information to the table, it appears that the following versions cannot be tested because the content process crashes (any new tab crashes): v50.0a1, v66.0a1, v71.0a1, v83.0a1, v86.0a1. These versions have to be forced open with wayland. Version v96.0a1 reproduces the issue as described in comment 0. This bug is not a regression and it may have a connection to the hardware configuration.

I have attached the about:support information of the latest Nightly on the affected machine.
Let me know if there is more I can help with.

Comment 7

[Emilio Cobos Álvarez (:emilio)]

Can you run mozregression with MOZ_ENABLE_WAYLAND=1 MOZ_DISABLE_CONTENT_SANDBOX=1? That should avoid the tab crashes, with that I can run at least as far as FF48 (probably more).

Comment 8

[Daniel Bodea [:danibodea]]

I wish I could help, but the mozregression-gui version does not seem to work in Wayland and the mozregression CLI version could not be installed.
I could provide with a regressor investigation if you could help me with some steps to install/run mozregression in Wayland.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

(In reply to Bodea Daniel [:danibodea] from comment #8)

I wish I could help, but the mozregression-gui version does not seem to work in Wayland and the mozregression CLI version could not be installed.

How not? On a terminal, you can:

$ pip3 install --user mozregression

And then you should be able to run mozregression. If that's failing, I need a more specific error to help, how is it failing?

Comment 10

[Daniel Bodea [:danibodea]]

Attachment: mozregression still does not work

I've tried the command you've specified in one of the comments above, it appeared as if it was installing, but mozregression still does not work. Waiting for your opinion.

Comment 11

[Daniel Bodea [:danibodea]]

This issue reproduces on 3 different systems that have been tested so far. It is not specific to 1 system.

Comment 12

[Emilio Cobos Álvarez (:emilio)]

It seems you don't have ~/.local/bin in your PATH, does using ~/.local/bin/mozregression rather than just mozregression work?

Comment 13

[Daniel Bodea [:danibodea]]

Yes! It appears it does.

Steps to re-attempt investigation for a regressor:

1. Open the terminal
2. type: export MOZ_ENABLE_WAYLAND=1
3. type: export MOZ_DISABLE_CONTENT_SANDBOX=1
4. type: ~/.local/bin/mozregression --launch 59

• v60.0a1 - can't be tested since it does not have PiP implemented, and neither is wayland.

5. type: ~/.local/bin/mozregression --launch 69

• v70.0a1 - wayland is implemented, but PiP isn't.

6. type: ~/.local/bin/mozregression --launch 79

• v80.0a1 - "wayland/drm" implemented and PiP also in it's early stages; the issue reproduces!

7. Starting a bisection between the last 2 versions above.
   type: ~/.local/bin/mozregression --good 69 --bad 79

• v70.0a1 - wayland is implemented, but PiP isn't. - setting result as GOOD.
• v80.0a1 - "wayland/drm" implemented and PiP also in it's early stages; the issue reproduces! - setting result as BAD.
• v71.0a1 - wayland is implemented, but PiP isn't. - setting result as GOOD.
• v72.0a1 - wayland and PiP are implemented; the issue reproduces! - setting result as BAD.
• 72.0a1 (20191029212748) - wayland is implemented, PiP toggle is displayed but isn't working at all. - setting result as GOOD to get e newer build where PiP works.
• 72.0a1 (20191109093718) - wayland and PiP are implemented, the issue reproduces!

Based on the testing results detailed above, this bug is not a regressor but is reproducing since its implementation.
Need Info me if further investigation is needed.

Comment 15

[Emilio Cobos Álvarez (:emilio)]

Ah, d'oh, indeed I can reproduce, but I misinterpreted your report. I can resize it from the corners. Let's dupe the other way around since bug 1739622 was older.