Closed Bug 1757953 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33048 - [@container] Remove size() function

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33048 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33048
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[@container] Remove size() function

Since we're anyway going to need it for style() queries eventually,
I have kept the parsing and expression-node code for supporting that
grammar. I added some unit test coverage for the related parsing code
since that is now otherwise unreachable.

Also, in query-evaluation.html, I converted the tests which cover
the grammar/evaluation of queries inside size() to style() tests,
since I think those tests are still valuable.

Fixed: 1300546
Change-Id: Ic5968833a63ca7b865c98992963f8113c46e1ec2
Reviewed-on: https://chromium-review.googlesource.com/3497743
WPT-Export-Revision: 5bef24d4828340875830866a5df5e53313a27ae8

PR 33048 applied with additional changes from upstream: 353e94d86cfb6eaf4838b79ad09e78978bede734, 974633788f17c1a1ecf963a9b4c0ea979da00aa8, 02e8d04ebd2f16ac9b326c648053075f3a03376d, 7718c6a1ed8eece61d99cc0d70d788d92276b919, 70b109f44abebedb75a552de9db294a019a1307d, 9a4e0d7e461045d7e761a0b6b428c3657e9cbd2c, e9d077eb04e5e7b38f638ba89e9dfa745dc11f36, 5ca555247283c0ecad9ba973c73bcd2804495517, 911e0e7d804f3ae7f381b03e8bff0d88ccc0ac21, 8642ffa759c1e06d7a408b31c1507262038ef9f6, 810b6c9097ee568326e239963449301f6dc568b5, 99f02f165b0d2d890b8fd9016c28daa1c7c5708c, 14a35c1ed5d4ab1dd4cada5b26ff9344512ba8fb, aac1ad269ad1683170b8a09f9b9490293e23c2ba, c7ad543a07688da7ec0e83d3ef3a8a7f7e90652e, 483811bbaa5f29305e78d075960bcbd69b67f61a
Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 85 tests

Status Summary

Firefox

OK : 5
PASS : 5[Gecko-linux1804-64-tsan-qr-opt] 19[Gecko-linux1804-64-domstreams-qr-debug] 22[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub]
FAIL : 6[Gecko-linux1804-64-domstreams-qr-debug] 19[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub]
ERROR: 47

Chrome

OK : 5
PASS : 22
FAIL : 19
ERROR: 47

Safari

OK : 51
PASS : 157
FAIL : 249
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-contain/container-queries/animation-container-size.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/animation-container-type-dynamic.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/animation-nested-animation.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/animation-nested-transition.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/aspect-ratio-feature-evaluation.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/at-container-parsing.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/auto-scrollbars.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/backdrop-invalidation.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/canvas-as-container-005.html
Focusable after container size change: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-contain/container-queries/canvas-as-container-006.html
Focusable after container size change: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-contain/container-queries/conditional-container-status.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/container-for-shadow-dom.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/container-inner-at-rules.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/container-name-invalidation.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/container-nested.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/container-selection.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/container-size-invalidation.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/container-type-invalidation.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/counters-flex-circular.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/deep-nested-inline-size-containers.html: ERROR (Chrome: ERROR, Safari: ERROR)
/css/css-contain/container-queries/display-contents.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/display-none.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/font-relative-units-dynamic.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/font-relative-units.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/fragmented-container-001.html
Children of fragmented inline-size container should match inline-size of first fragment: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-contain/container-queries/get-animations.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/iframe-invalidation.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/ineligible-containment.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/inline-size-and-min-width.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/inline-size-containment-vertical-rl.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/inline-size-containment.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/multicol-container-001.html
Children of multicol inline-size container should match inline-size of the container: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-contain/container-queries/never-match-container.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/orthogonal-wm-container-query.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/percentage-padding-orthogonal.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/pseudo-elements-001.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/pseudo-elements-003.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/query-content-box.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/query-evaluation.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/reattach-container-with-dirty-child.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/size-container-no-principal-box.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/size-feature-evaluation.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/style-change-in-container.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/svg-root-size-container.html
SVG text querying SVG root size container: FAIL (Chrome: FAIL, Safari: FAIL)
div in foreignObject querying SVG root size container: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-contain/container-queries/top-layer-dialog-container.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/top-layer-dialog.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/top-layer-nested-dialog.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/transition-scrollbars.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/transition-style-change-event.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/unsupported-axis.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/viewport-units-dynamic.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/viewport-units.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/canvas-as-container-003.html: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-contain/container-queries/canvas-as-container-004.html: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-contain/container-queries/change-display-in-container.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-contain/container-queries/counters-in-container-dynamic.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-contain/container-queries/counters-in-container.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-contain/container-queries/custom-layout-container-001.https.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-contain/container-queries/display-in-container.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-contain/container-queries/fieldset-legend-change.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-contain/container-queries/inline-size-bfc-floats.html: FAIL (Chrome: FAIL, Safari: PASS)
/css/css-contain/container-queries/multicol-inside-container.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-contain/container-queries/pseudo-elements-002.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-contain/container-queries/resize-while-content-visibility-hidden.html: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-contain/container-queries/top-layer-dialog-backdrop.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/88172f6daeb9
[wpt PR 33048] - [@container] Remove size() function, a=testonly

https://hg.mozilla.org/mozilla-central/rev/88172f6daeb9

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.