Closed Bug 1758003 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33050 - Revert "[FedCM] Make privacy policy url required"

Categories

(Core :: DOM: Security, task, P4)

task

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream][domsecurity-backlog])

Sync web-platform-tests PR 33050 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33050
Details from upstream follow.

Leonard Grey <lgrey@chromium.org> wrote:

Revert "[FedCM] Make privacy policy url required"

This reverts commit 09408255f5fc40e54ce586e5f3e4048dd87a6f58.

Reason for revert: Tree closer; failed compile https://ci.chromium.org/p/chromium/builders/ci/Cast%20Audio%20Linux

Original change's description:

[FedCM] Make privacy policy url required

Currently we allow no privacy policy url to be specified in the client
metadata. This CL changes that by surfacing an error if the JSON parser
returns an empty value for |privacy_policy_url|. We also sanity check
the privacy policy, and if it is an invalid URL then reject. In order to
properly surface the problem about missing privacy policy, we add a
specific console error message. We also add a new value to the
FederatedAuthRequestIssueReason so that a similar message can be
displayed in the Issues panel.

Bug: 1293913
Change-Id: I5dbb6e6a1005db33dccafb7977fb7cced8f871d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3499232
Reviewed-by: Yi Gu \<yigu@chromium.org>
Reviewed-by: Andrey Kosyakov \<caseq@chromium.org>
Reviewed-by: Christian Biesinger \<cbiesinger@chromium.org>
Reviewed-by: Ken Buchanan \<kenrb@chromium.org>
Commit-Queue: Nicolás Peña \<npm@chromium.org>
Cr-Commit-Position: refs/heads/main@{#977304}

Bug: 1293913
Change-Id: I88831f9e5bef95d5e09c8be83f000db60ca3d5d4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3498198
Bot-Commit: Rubber Stamper \<rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Leonard Grey \<lgrey@chromium.org>
Commit-Queue: Leonard Grey \<lgrey@chromium.org>
Cr-Commit-Position: refs/heads/main@{#977310}

PR 33050 applied with additional changes from upstream: a5996ace0256d702602318cd824c816066eb792b, 45b506b5acfe216e1fd1784f86a9bc631d27c8bf
Component: web-platform-tests → DOM: Security
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream][domsecurity-backlog]
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c9064fda19f5
[wpt PR 33050] - Revert "[FedCM] Make privacy policy url required", a=testonly
Test result changes from PR not available.
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.