1758006 - [wpt-sync] Sync PR 33051 - Reland "[FedCM] Make privacy policy url required"

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 33051 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33051
Details from upstream follow.

Nicolás Peña Moreno <[e-mail]> wrote:

Reland "[FedCM] Make privacy policy url required"

This is a reland of commit 09408255f5fc40e54ce586e5f3e4048dd87a6f58

Original change's description:

[FedCM] Make privacy policy url required

Currently we allow no privacy policy url to be specified in the client
metadata. This CL changes that by surfacing an error if the JSON parser
returns an empty value for |privacy_policy_url|. We also sanity check
the privacy policy, and if it is an invalid URL then reject. In order to
properly surface the problem about missing privacy policy, we add a
specific console error message. We also add a new value to the
FederatedAuthRequestIssueReason so that a similar message can be
displayed in the Issues panel.

Bug: 1293913
Change-Id: I5dbb6e6a1005db33dccafb7977fb7cced8f871d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3499232
Reviewed-by: Yi Gu \<[e-mail]>
Reviewed-by: Andrey Kosyakov \<[e-mail]>
Reviewed-by: Christian Biesinger \<[e-mail]>
Reviewed-by: Ken Buchanan \<[e-mail]>
Commit-Queue: Nicolás Peña \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#977304}

Bug: 1293913
Change-Id: If7eb1ce808ba0fa995cb5b7be13e5bd5120e20bb
Reviewed-on: https://chromium-review.googlesource.com/3498729
WPT-Export-Revision: 02adb23893600f9ef30e60f0d5adadf466eecb37

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 33051 applied with additional changes from upstream: a5996ace0256d702602318cd824c816066eb792b, 45b506b5acfe216e1fd1784f86a9bc631d27c8bf, 206491af1ac7c2400c0f45cca4ea133dd2845762

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=None

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=d37062383fab5c14fe24d3f2ae55c73355a6a0d9

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/950ba5f102fd
[wpt PR 33051] - Reland "[FedCM] Make privacy policy url required", a=testonly

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Test result changes from PR not available.

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/950ba5f102fd