Closed Bug 1758008 Opened 2 years ago Closed 2 years ago

set mimetype for parts in crash report for content crashes

Categories

(Toolkit :: Crash Reporting, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
101 Branch
Tracking Status
firefox101 --- fixed

People

(Reporter: willkg, Assigned: gsvelto)

References

Details

Attachments

(1 file)

This code here:

https://searchfox.org/mozilla-central/rev/ad7ecfa618ec3a65db8405d9f1125059fe4a6a15/toolkit/crashreporter/CrashSubmit.jsm#238-268

sets the mimetype only for the JSON-encoded extra field, but not for other parts.

It should set the mimetype for minidumps to application/octet-stream. I think it should do the same for memory_report, but ... I don't know what format that's in.

This is all to alleviate parsing problems and get crash reporting closer to the current crash report payload spec (https://socorro.readthedocs.io/en/latest/spec_crashreport.html).

I don't know offhand how much it affects crash ingestion. I'm guessing there might be edge cases where it causes things to go awry, but otherwise doesn't affect things as they stand currently. It was a bit of a surprise earlier this week, though.

I can probably do this work if we're agreed on the problem statement and plan and someone tells me what mimetype to use for memory_report.

Assignee: nobody → gsvelto
Status: NEW → ASSIGNED

I haven't landed this yet because I was looking for a way to test it using the minimal crash reporter server simulator in m-c... and while I was testing I noticed that the MIME types weren't being populated correctly even after my change. It seems that somehow we're still picking up the overrides in /etc/mime.types instead.

I've been thinking about creating a mini-collector that you could do an HTTP POST to and it would let you assert things through an API about the extracted payload. Does that sound like something that would help here?

It could be useful for doing more sensible integration testing, right now we use this which is very limited as you can see.

Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1679d02a6843
Specify the MIME types of all the files comprising a crash report when submitting it r=willkg
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch
URL: 1757786
See Also: → 1757786
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: