1758037 - [wpt-sync] Sync PR 33054 - Revert "[FedCM] Split get() into get()+login()"

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 33054 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33054
Details from upstream follow.

Keishi Hattori <[e-mail]> wrote:

Revert "[FedCM] Split get() into get()+login()"

This reverts commit a6fba024e6fdead47455a413362261326e0ab7a6.

Reason for revert: Might have caused compile failure
https://ci.chromium.org/p/chromium/builders/ci/linux-archive-rel/62048?

Original change's description:

[FedCM] Split get() into get()+login()

This is a consequence of
https://github.com/fedidcg/FedCM/commit/e49c2bb2fd949ef048f4f5e25cff26c3c7f72d91

Bug: 1300009
Change-Id: I36839e0e5748d1014e624d64f40d393fec4d2b91
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3499423
Reviewed-by: Yi Gu \<[e-mail]>
Reviewed-by: Sam Goto \<[e-mail]>
Commit-Queue: Christian Biesinger \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#977460}

Bug: 1300009
Change-Id: I6a1e3250f82f4111eac6c841127d044d197af97f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true

Reviewed-on: https://chromium-review.googlesource.com/3499935
WPT-Export-Revision: 0e1b5c099c34bc30933590cfab12f7f35a8c45b2

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 33054 applied with additional changes from upstream: a5996ace0256d702602318cd824c816066eb792b, 5ace2e6a4c5064ff52e09d0762c9498de4a45c37

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=None

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca00cb6349e4a2fbb9627a509c7a48a9c03ef58b

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests

Status Summary

Firefox

OK : 1
FAIL : 1
TIMEOUT: 1

Chrome

OK : 1
FAIL : 1
TIMEOUT: 1

Safari

OK : 1
FAIL : 1
TIMEOUT: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/credential-management/fedcm-network-requests.sub.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-domstreams-qr-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
Test that COEP policy do not apply to FedCM requests: FAIL (Chrome: FAIL, Safari: FAIL)
/credential-management/fedcm.https.html: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-domstreams-qr-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: TIMEOUT)

Tests Disabled in Gecko Infrastructure

/credential-management/fedcm-network-requests.sub.https.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-domstreams-qr-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt] (Chrome: OK, Safari: OK)
/credential-management/fedcm.https.html: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-domstreams-qr-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: TIMEOUT)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e53525c9313
[wpt PR 33054] - Revert "[FedCM] Split get() into get()+login()", a=testonly

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/3e53525c9313