1758055 - Establish file system content and parent process IPC

Status: RESOLVED FIXED

(Core :: DOM: File, task, P3)

Comment 1

[Jari Jalkanen]

Attachment: WIP: Bug 1758055 - Establish file system content and parent process IPC.

Comment 2

[Phabricator Automation]

Comment on attachment 9266433 [details]
WIP: Bug 1758055 - Establish file system content and parent process IPC.

Revision D140300 was moved to bug 1758324. Setting attachment 9266433 [details] to obsolete.

Comment 3

[Jari Jalkanen]

Attachment: Bug 1758055 - Establish file system content and parent process IPC. r=jesup,janv,#dom-storage-reviewers,#ipc-reviewers

Comment 4

[Jari Jalkanen]

Attachment: Bug 1758055 - Move DOM bindings to api folder. r=jesup,janv,#dom-storage-reviewers

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ffa45c6af89
Move DOM bindings to api folder. r=janv,dom-storage-reviewers

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/8ffa45c6af89

Comment 7

[Jan Varga [:janv]]

Attachment: Bug 1758055 - Add PrincipalInfo to PBackgroundFileSystem construction; r=#dom-storage

These changes are partially copied from D148179 (created by jesup). We need to
be able to create correct origin directories from the very beginning.

Comment 8

[Jan Varga [:janv]]

Attachment: Bug 1758055 - Remove unnecessary origin argument from GetRoot; r=#dom-storage

The origin string is supposed to be generated from PrincipalInfo using a
dedicated QuotaManager method.

Depends on D149259

Comment 9

[Jari Jalkanen]

Attachment: Bug 1758055 - Remove unnecessary origin argument from GetRoot; r=#dom-storage

The origin string is supposed to be generated from PrincipalInfo using a
dedicated QuotaManager method.

Depends on D149259

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e304bf129b7
Establish file system content and parent process IPC. r=janv,dom-storage-reviewers

Comment 11

[Sandor Molnar[:smolnar]]

Backed out changeset 8e304bf129b7 (bug 1758055) for causing build bustages in nsISupportsImpl

Backout link: https://hg.mozilla.org/integration/autoland/rev/d595070ce37139fff6e6688a4f192737fc0f8bc8

Push with failures

Failure log

from Unified_cpp_dom_fs_test_gtest0.cpp:2:
[task 2022-06-23T14:02:51.044Z] 14:02:51     INFO -  /builds/worker/checkouts/gecko/dom/fs/test/gtest/FileSystemMocks.h: In member function 'MozExternalRefCountType mozilla::dom::fs::test::TestPromiseListener<SuccessHandler, ErrorHandler, MilliSeconds>::AddRef()':
[task 2022-06-23T14:02:51.044Z] 14:02:51    ERROR -  /builds/worker/workspace/obj-build/dist/include/nsISupportsImpl.h:33:3: error: static assertion failed: Reference-counted class WaitablePromiseListener should not have a public destructor. Make this class's destructor non-public
[task 2022-06-23T14:02:51.044Z] 14:02:51     INFO -     static_assert(!mozilla::IsDestructible<X>::value,      \
[task 2022-06-23T14:02:51.044Z] 14:02:51     INFO -     ^
[task 2022-06-23T14:02:51.044Z] 14:02:51     INFO -  /builds/worker/workspace/obj-build/dist/include/nsISupportsImpl.h:669:5: note: in expansion of macro 'MOZ_ASSERT_TYPE_OK_FOR_REFCOUNTING'
[task 2022-06-23T14:02:51.044Z] 14:02:51     INFO -       MOZ_ASSERT_TYPE_OK_FOR_REFCOUNTING(_class)

Comment 12

[Donal Meehan [:dmeehan]]

Jari Jalkanen, a reminder that we are in soft code freeze for 103.
This looks like a large change to land during code freeze?

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f0203d4d8553
Establish file system content and parent process IPC. r=janv,dom-storage-reviewers

Comment 14

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/f0203d4d8553

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/956cb953a945
Add PrincipalInfo to PBackgroundFileSystem construction; r=dom-storage-reviewers,jari
https://hg.mozilla.org/integration/autoland/rev/06134781ceaf
Remove unnecessary origin argument from GetRoot; r=dom-storage-reviewers,jari

Comment 16

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/956cb953a945
https://hg.mozilla.org/mozilla-central/rev/06134781ceaf

Comment 17

[Jari Jalkanen]

So the test which was fixed in the second patch was made to pass also in the first one, and both of them were landed after the code freeze.