175808 - Crash following theme install - Trunk M130A [@ js_RemoveRoot]

Status: RESOLVED WORKSFORME

(Core Graveyard :: Installer: XPInstall Engine, defect)

Description

[greer]

Releases dating beck to M1.0 show this signature in relation to crashes
following a theme download/change. Over to JS based on the sig. Brendan should
this go to XPInstall instead?

Stack Trace: 

	 js_RemoveRoot	[c:/builds/seamonkey/mozilla/js/src/jsgc.c  line 436]
	 JS_RemoveRoot	[c:/builds/seamonkey/mozilla/js/src/jsapi.c  line 1498]
	 nsXPITriggerInfo::~nsXPITriggerInfo
[c:/builds/seamonkey/mozilla/xpinstall/src/nsXPITriggerInfo.cpp  line 120]
	 nsXPInstallManager::~nsXPInstallManager
[c:/builds/seamonkey/mozilla/xpinstall/src/nsXPInstallManager.cpp  line 119]
	 nsXPInstallManager::`scalar deleting destructor'
	 nsXPInstallManager::Release
[c:/builds/seamonkey/mozilla/xpinstall/src/nsXPInstallManager.cpp  line 128]
	 XPCJSRuntime::GCCallback
[c:/builds/seamonkey/mozilla/js/src/xpconnect/src/xpcjsruntime.cpp  line 539]
	 js_GC	[c:/builds/seamonkey/mozilla/js/src/jsgc.c  line 1400]
	 js_ForceGC	[c:/builds/seamonkey/mozilla/js/src/jsgc.c  line 994]
	 JS_GC	[c:/builds/seamonkey/mozilla/js/src/jsapi.c  line 1660]
	 nsJSContext::Notify
[c:/builds/seamonkey/mozilla/dom/src/base/nsJSEnvironment.cpp  line 1598]
	 nsTimerManager::FireNextIdleTimer
[c:/builds/seamonkey/mozilla/xpcom/threads/nsTimerImpl.cpp  line 591]
	 nsCOMPtr_base::assign_from_helper
[c:/builds/seamonkey/mozilla/xpcom/glue/nsCOMPtr.cpp  line 78]
	 nsAppShellService::Run
[c:/builds/seamonkey/mozilla/xpfe/appshell/src/nsAppShellService.cpp  line 472]
	 main1	[c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp  line 1538]
	 nsAppShellService::Run
[c:/builds/seamonkey/mozilla/xpfe/appshell/src/nsAppShellService.cpp  line 472]
	 main1	[c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp  line 1538]
	 main	[c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp  line 1886]
	 WinMain	[c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp  line 1906]
	 WinMainCRTStartup()
	 KERNEL32.DLL + 0x1ca90 (0x77e9ca90)
 
 	Source File : c:/builds/seamonkey/mozilla/js/src/jsgc.c line : 436
     (12788863)	Comments: closing Mozilla from the "x" button
     (12758447)	Comments: just installed new theme (low-fi classic) and was
closing windows in order to relaunch the application.
     (12749986)	Comments: Choosing a new theme
     (12738553)	URL: mozilla.deskmod.com/?show=showcat&cat_name=mozilla
     (12697865)	Comments: Finshed downlading/ installing skin Orbitz Retro
     (12692725)	Comments: Using Mozilla 1.2b I installed some Add-Ons from
mozdev (optimoz and a theme).    When going to the Preferences it hung up...
     (12690724)	Comments: Exit browser after installing newest orbit 3 theme

Also on the Trunk:
 Unique Users  8
   8 Windows
   1 2002101908
   1 2002101808
   2 2002101708
   1 2002101604
   3 2002101308
(12539076 - 2002101308) - [Windows NT  5.0 build 2195]: After installing a new
skin  I closed mozilla.  The last window I closed was the one showing the
success message of the installation.   URL:
http://www.ncp.de/deutsch/security/securityfeatures/index.html
(12752518 - 2002101808) - [Windows NT  5.1 build 2600]: I had just downloaded a
theme and installed and was closing the browser when I received the error

Comment 1

[Phil Schwartau]

A developer will know more than I about this, but the stack does
seem to me to implicate something other than JS Engine. The frames
involving JS_RemoveRoot, js_RemoveRoot at the top of the stack are
not likely to be the cause of the crash, which occurs farther down.
This is often the result of the JS client using a bad JSContext.

Reassigning to XPInstall for further analysis -

Comment 2

[Jay Patel [:jay]]

Updating summary with Trunk M120B since this is a topcrash with Mozilla 1.2 Beta
and the latest Trunk builds.  Also adding qawanted keyword to see if we can get
this reproduced.

Many users are crashing trying to install themes.  Not sure if it is a problem
in our code or due to bad themes.  Here is the latest from Talkback:

MozillaTrunk:
js_RemoveRoot   7
		 175808 	 NEW 	  	 [e-mail] 	 --- 	 2002-10-21 
BBID range: 13189836 - 13519117
Min/Max Seconds since last crash: 656 - 12028
Min/Max Runtime: 656 - 12028
Crash data range: 2002-10-28 to 2002-11-04
Build ID range: 2002102704 to 2002110408
Keyword List : 
Stack Trace: 

	 js_RemoveRoot	[d:/builds/seamonkey/mozilla/js/src/jsgc.c  line 436]
	 JS_RemoveRoot	[d:/builds/seamonkey/mozilla/js/src/jsapi.c  line 1498]
	 nsXPITriggerInfo::~nsXPITriggerInfo
[d:/builds/seamonkey/mozilla/xpinstall/src/nsXPITriggerInfo.cpp  line 120]
	 nsXPInstallManager::~nsXPInstallManager
[d:/builds/seamonkey/mozilla/xpinstall/src/nsXPInstallManager.cpp  line 119]
	 nsXPInstallManager::`scalar deleting destructor'
	 nsXPInstallManager::Release
[d:/builds/seamonkey/mozilla/xpinstall/src/nsXPInstallManager.cpp  line 128]
	 XPCJSRuntime::GCCallback
[d:/builds/seamonkey/mozilla/js/src/xpconnect/src/xpcjsruntime.cpp  line 539]
	 jsds_GCCallbackProc	[d:/builds/seamonkey/mozilla/js/jsd/jsd_xpc.cpp  line 516]
	 js_GC	[d:/builds/seamonkey/mozilla/js/src/jsgc.c  line 1400]
	 js_ForceGC	[d:/builds/seamonkey/mozilla/js/src/jsgc.c  line 994]
	 nsCOMPtr_base::assign_from_helper
[d:/builds/seamonkey/mozilla/xpcom/glue/nsCOMPtr.cpp  line 78]
	 nsDOMSOFactory::Observe
[d:/builds/seamonkey/mozilla/dom/src/build/nsDOMFactory.cpp  line 231]
	 nsObserverService::NotifyObservers
[d:/builds/seamonkey/mozilla/xpcom/ds/nsObserverService.cpp  line 213]
	 NS_ShutdownXPCOM	[d:/builds/seamonkey/mozilla/xpcom/build/nsXPComInit.cpp 
line 694]
	 main	[d:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp  line 1896]
	 WinMain	[d:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp  line 1906]
	 WinMainCRTStartup()
	 kernel32.dll + 0x214c7 (0x77e814c7)
 
 	Source File :
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/js/src/jsgc.c line : 436
     (13519117)	URL: http://astalavista.box.sk/
     (13442397)	URL:
http://slashdot.org/article.pl?sid=02/08/18/1519217&mode=nested&tid=109
     (13442397)	Comments: just applied 1.2b lo-fi theme

And from Mozilla 1.2 Beta:
 (12)   45   js_RemoveRoot
 
  175808 NEW [e-mail] --- 2002-10-21

   BBID range:            13195095 - 13588401
   Secs since last crash: 125 (min) - 423031 (max)
   Total Runtime:         125 (min) - 628655 (max)
   Crash date range:      2002-10-28 to 2002-11-06
   Crash date range:      2002101612 to 2002101612
   Unique Users:          31


   Stack Trace: 
         js_RemoveRoot	[c:/builds/seamonkey/mozilla/js/src/jsgc.c  line 436] 
	 JS_RemoveRoot	[c:/builds/seamonkey/mozilla/js/src/jsapi.c  line 1498] 
	 nsXPITriggerInfo::~nsXPITriggerInfo
[c:/builds/seamonkey/mozilla/xpinstall/src/nsXPITriggerInfo.cpp  line 120] 
	 nsXPInstallManager::~nsXPInstallManager
[c:/builds/seamonkey/mozilla/xpinstall/src/nsXPInstallManager.cpp  line 119] 
	 nsXPInstallManager::`scalar deleting destructor'  
	 nsXPInstallManager::Release
[c:/builds/seamonkey/mozilla/xpinstall/src/nsXPInstallManager.cpp  line 128] 
	 XPCJSRuntime::GCCallback
[c:/builds/seamonkey/mozilla/js/src/xpconnect/src/xpcjsruntime.cpp  line 539] 
	 js_GC	[c:/builds/seamonkey/mozilla/js/src/jsgc.c  line 1400] 
	 js_ForceGC	[c:/builds/seamonkey/mozilla/js/src/jsgc.c  line 994] 
	 nsCOMPtr_base::assign_from_helper
[c:/builds/seamonkey/mozilla/xpcom/glue/nsCOMPtr.cpp  line 78] 
	 nsDOMSOFactory::Observe
[c:/builds/seamonkey/mozilla/dom/src/build/nsDOMFactory.cpp  line 231] 
	 nsObserverService::NotifyObservers
[c:/builds/seamonkey/mozilla/xpcom/ds/nsObserverService.cpp  line 213] 
	 NS_ShutdownXPCOM	[c:/builds/seamonkey/mozilla/xpcom/build/nsXPComInit.cpp 
line 694] 
	 main	[c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp  line 1896] 
	 WinMain	[c:/builds/seamonkey/mozilla/xpfe/bootstrap/nsAppRunner.cpp  line 1906] 
	 WinMainCRTStartup()  
	 KERNEL32.DLL + 0x1ca90 (0x77e9ca90)   

    Source File:  c:/builds/seamonkey/mozilla/js/src/jsgc.c line : 436

   (13530518) Comments: Installing some 1.2 themes.
   (13456200) Comments: Restarting browser to activate new theme. (wood) All is
okay after restart.
   (13387175) Comments: Changed skin and click ok. The browser crashed  but
restarting the program   the skin had changed anyway.
   (13292441)      URL: rd.cenega.pl
   (13268378) Comments: installing the pinball theme/skin
   (13268378) Comments: installing the pinball theme/skin
   (13241881) Comments: Installing theme
   (13241881) Comments: Installing theme

Comment 3

[Daniel Veditz [:dveditz]]

The content of the theme is irrelevant at the point indicated by the stack
trace. Nothing in that area of xpinstall has changed in forever, why are we just
seeing this crash now? Maybe it's just the popularity of 1.2b

Comment 4

[Brant Gurganus]

Most XPIs will crash for me following this procedure:
1. Click link.
2. Click OK to alert.
3. When finished click OK to alert telling you to restart browser.
4. Close navigator.
5. Close alert than installation is complete.

This almost consistently causes a crash.

Comment 5

[Jay Patel [:jay]]

Updating summary with M130A since this is showing up in Mozilla 1.3 Alpha. 
However, there are only 6 incidents out of a total sample of 12000+ from the
last 10 days...so marking worksforme.

I know we have some good checks in current builds that won't allow you to
install old themes...so we shouldn't see this problem anymore.

Comment 6

[Jay Patel [:jay]]

whoops...i meant to mark this worksforme.

Comment 7

[Jay Patel [:jay]]

done.