1758085 - Combined items (zoom controls, clipboard cut/copy/paste controls, profiler button) are misaligned inside the Overflow Menu

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P3)

Description

[Anca Soncutean, Desktop QA]

Attachment: screeshot issue.png

Affected versions

• 99.0a1 (2022-03-03)

Affected platforms

• Windows 10
• macOS 11.0
• Ubuntu 20.04

Steps to reproduce

1. Go to Menu - More tools - Customise toolbar
2. Drag several items inside the Overflow Menu (make sure to include “Profiler” and “Edit Controls”)
3. Observe the Overflow Menu

Expected result

• All items are aligned.

Actual result:

• “Profiler”, “Edit Controls” are not aligned with the rest of the items.

Regression range

• Last good revision: 1ecdb4c33adf2064c910cbb15e66b6f066c9a5ce
• First bad revision: 41da8c4b62186e3c174278a8c97b375a00a23c2a
• Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=1ecdb4c33adf2064c910cbb15e66b6f066c9a5ce&tochange=41da8c4b62186e3c174278a8c97b375a00a23c2a
  Potential regressor: 1747437

Other notes

• The issue is more visible inside the Customise page

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1747437

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:sfoster, since you are the author of the regressor, bug 1747437, could you take a look?
For more information, please visit auto_nag documentation.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Thanks for catching this, I'll take a look.

Comment 4

[Sam Foster [:sfoster] (he/him)]

Attachment: Bug 1758085 - Restore correct margins to .toolbaritem-combined-buttons children in the overflow menu. r?dao!"

• With the @anyPanel@ changes, the specificity changed such that the margins from the .widget-overflow-list .toolbarbutton-1 rule were overriding those set by the rule intended to zero them panelview .toolbaritem-combined-buttons > toolbarbutton.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1747437

Comment 6

[Donal Meehan [:dmeehan]]

:sfoster reminder that we are in the final week of beta for 99.
We could take an uplift request, if this get's landed in central early this week

Comment 7

[:Gijs (he/him)]

(In reply to Donal Meehan [:dmeehan] from comment #6)

:sfoster reminder that we are in the final week of beta for 99.
We could take an uplift request, if this get's landed in central early this week

This patch on central conflicts with the move to panelUI-shared.css, so I wonder if we should back out 1747437 from 99 to be on the safe side. Thoughts, Sam?

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e645597fc522
Restore correct margins to .toolbaritem-combined-buttons children in the overflow menu. r=Gijs"

Comment 9

[Sam Foster [:sfoster] (he/him)]

(In reply to :Gijs (he/him) from comment #7)

This patch on central conflicts with the move to panelUI-shared.css, so I wonder if we should back out 1747437 from 99 to be on the safe side. Thoughts, Sam?

Yeah I think I'm inclined to agree. I'll prepare a backout patch for 99.

Comment 10

[Sam Foster [:sfoster] (he/him)]

Attachment: bug-1758085-beta.patch

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1747437
[User impact if declined]:
When some items are placed in the overflow menu, they are not correctly aligned to the left/leading margin
[Is this code covered by automated tests?]:
No
[Has the fix been verified in Nightly?]:
We're applying a different fix in Nightly. This fix for beta backs out the original patch
[Needs manual test from QE? If yes, steps to reproduce]:
See Bug 1758085#c0 - add some items including zoom and profile to the overflow menu and confirm their left (in LTR) edges correctly line up.
[List of other uplifts needed for the feature/fix]:
None
[Is the change risky?]: No / low risk
[Why is the change risky/not risky?]:
Reverts a well constrained patch, affecting a single browser stylesheet
[String changes made/needed]: None

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e645597fc522

Comment 12

[Donal Meehan [:dmeehan]]

Comment on attachment 9268762 [details] [diff] [review]
bug-1758085-beta.patch

Approved for 99.0b7. Thanks.

Comment 13

[Anca Soncutean, Desktop QA]

Attachment: overflow menu.png

The issue is still visible on the latest Nightly 100.0a1 (2022-03-22), but only with the Overflow Menu inside the Customize page.

Comment 14

[Donal Meehan [:dmeehan]]

Setting 99 to unaffected, Bug 1747437 backed out via uplifting attachment 9268762 [details] [diff] [review] to beta for 99

Comment 15

[Sam Foster [:sfoster] (he/him)]

(In reply to Anca Soncutean [:Anca], Desktop Release QA from comment #13)

Created attachment 9268880 [details]
overflow menu.png

The issue is still visible on the latest Nightly 100.0a1 (2022-03-22), but only with the Overflow Menu inside the Customize page.

Oh thanks for spotting that. Can you file a new bug - can be the same regressor. I think it will make sense to create a new patch for the customize page case.

Comment 16

[Donal Meehan [:dmeehan]]

Comment on attachment 9268762 [details] [diff] [review]
bug-1758085-beta.patch

Clearing the beta flag + to remove it from relman filters, since 99 is "unaffected"

Comment 17

[Anca Soncutean, Desktop QA]

1760997(In reply to Sam Foster [:sfoster] (he/him) from comment #15)

(In reply to Anca Soncutean [:Anca], Desktop Release QA from comment #13)

Created attachment 9268880 [details]
overflow menu.png

The issue is still visible on the latest Nightly 100.0a1 (2022-03-22), but only with the Overflow Menu inside the Customize page.

Oh thanks for spotting that. Can you file a new bug - can be the same regressor. I think it will make sense to create a new patch for the customize page case.

Bug 1760997 was filled for the misalignment that is still visible inside the Customize page. As for the current bug based on the comments above, I will mark it as verified fixed, checked with the latest Nightly 100.0a1 , across platforms (Win 10, macOS 12.0, Ubuntu 20.04).