1758093 - [wpt-sync] Sync PR 33056 - Pre-paint: Don't mark ancestors for paint property update.

Status: RESOLVED FIXED

(Core :: Layout: Columns, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 33056 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33056
Details from upstream follow.

Morten Stenshorne <[e-mail]> wrote:

Pre-paint: Don't mark ancestors for paint property update.

When we're block-fragmented, it may be that we're not actually inside
the ancestor, so leave it alone.

I wish that the test could have been simpler, but this was the best I
could do. What's happening here on the pre-paint side, is that we won't
have entered the outer span when visiting the floated input element
(because it's handled by WalkMissedChildren(), because it's a float that
we broke before in an inline formatting context, and the second
fragmentainer doesn't have any lines). Thus, if we also mark the parent
of the input element (i.e. the outer span) for paint property update
while PaintPropertyTreeBuilder is processing the input element, we'll
never get around to handling it when we should, and won't reset the
flags, so that, if we run a pre-paint walk later on, one which doesn't
need a tree builder context, we'll crash when we get to the outer span,
since it suddenly wants a tree builder context in the middle of the
tree.

Bug: 1301281
Change-Id: If5ba04e491d632550eaef57f6ef5568369ea6335

Reviewed-on: https://chromium-review.googlesource.com/3497667
WPT-Export-Revision: 5d571b3ba18956709c997b242c97973c31ce61f6

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=None

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=7f4d9460858605da5beeaa8af8cde6736936c68a

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

PASS: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95cbd8e02512
[wpt PR 33056] - Pre-paint: Don't mark ancestors for paint property update., a=testonly

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/95cbd8e02512