Closed Bug 1758114 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 33057 - Remove DCHECKs in FloatRoundedRect::Radii::Expand()

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33057 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33057
Details from upstream follow.

Xianzhu Wang <wangxianzhu@chromium.org> wrote:

Remove DCHECKs in FloatRoundedRect::Radii::Expand()

The DCHECK failed when we calculated the inner bounds of an outline
with border-radius, if the outline had big negative outline-offset
and was on a box whose size was bigger than 2x outline width in one
dimension and smaller than 2x outline width in the other dimension.
In the case, FloatRoundedRect::Radii::Expand() was called with a
gfx::OutsetsF with mixed positive/negative components.

Remove the DCHECK as the case is valid. Will follow up for refactors
and cleanups.

Bug: 1301077
Change-Id: Id76b5587b83a6fd0c8fbf0dcea010dc1670f7c58

Reviewed-on: https://chromium-review.googlesource.com/3499896
WPT-Export-Revision: 0f5f63e0590cb5e7aae4ee2346bf5528e24dd335

Component: web-platform-tests → Layout
Product: Testing → Core
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4597af6dfefc [wpt PR 33057] - Remove DCHECKs in FloatRoundedRect::Radii::Expand(), a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/4597af6dfefc

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.