1758369 - Credit card logo in save/edit panel is displayed as generic for certain websites

Status: VERIFIED FIXED

(Toolkit :: Form Autofill, defect, P2)

Description

[Ciprian Georgiu, Desktop QA]

Note

• Bug found while verified https://bugzilla.mozilla.org/show_bug.cgi?id=1740527#c4

Affected versions

• latest Nightly 99.0a1
• RC3 98.0

Affected platforms

• Windows 10 x64
• macOS 11
• Ubuntu 18.04 x64

Preconditions

• browser.search.region set to US
• a valid credit card is saved in about:preferences

Steps to reproduce

1. Launch Firefox.
2. Navigate to https://www.ebay.com/.
3. Choose an item, then proceed to the checkout.
4. Enter the information in the credit card fields.
5. Update the credit card information that you've previously entered.
6. Observe the credit card logo from the door hanger.

Expected result

• The credit card logo is correctly displayed in the door hanger.

Actual result

• A generic credit card logo is displayed in the door hanger.

Suggested Severity

• S3, since this is not a regression, and only affects ebay from what I've tested so far.

Regression range

• Not a regression, this can be reproduced on the first builds after https://bugzilla.mozilla.org/show_bug.cgi?id=1740527 was implemented.

Additional notes

• The issue is not reproducing on https://mozilla.github.io/form-fill-examples/basic_cc.html
• I've used this site to generate a demo credit card https://www.prepostseo.com/tool/credit-card-generator

Comment 1

[Alin Ilea, Desktop Test Engineering]

Hi,

We encountered this issue as well on multiple websites, on Beta 99.0b1 and the latest Nightly 100.0a1: asos.co.uk, tesco.com, asda.com, screwfix.com, currys.co.uk.

Please let me know if separate bugs are needed for each website mentioned above.
Thanks!

Comment 2

[Tim Giles [:tgiles]]

Alin, I'm not able to reproduce on asos.co.uk. I'm on secure.asos.com for their check out and I'm able to see the test VISA card logo as expected. What card number did you use? And were you on a different payment site than secure.asos.com?

Tesco.com is the same as the ebay case, we're not trimming the credit card number before trying to search for a network match. Since there's spaces in the card number, we don't return a valid network match therefore we show the generic logo.

Not able to create an account for screwfix. Alin, if we have a test account for this could you message me the credentials so I can see what's going on with our credit card submission handling. Thanks!

Currys.co.uk is the same as Tesco.com and ebay, we're not trimming the credit card number before trying to search for a network match.

Comment 3

[Alin Ilea, Desktop Test Engineering]

Attachment: asos cc logo issue.mp4

Tim, I attached here a video of my behavior. I tried with multiple CC Visa card numbers: 4267662953520654, 4485163092477407, 4253771142675810, 4532484770494909, 4119638430740339, 4929873107978496 (the card logo is displayed accordingly on other websites with the same CC numbers). I am using the same secure.asos.com checkout.
Tested on Windows 10, Nightly 100.0a1 (2022-03-09), en-GB locale build with browser.search.region set to UK. Tested with en-US locale build with region set to US as well but I got the same result. Please let me know if you need any other information.

Also, that list of websites is the result of the UK region testing. We will update the list after we finish the FR and DE regions as well, if the issue is reproducible on some websites from that regions as well.
Sent the testing credentials for Screwfix in private.

Thanks a lot!

Comment 4

[Tim Giles [:tgiles]]

screwfix.com has the same issue of spaces in the submitted card number. Same as ebay, tesco, and currys.

Okay, I'm able to reproduce on secure.asos.com. Since the site doesn't allow you to paste in a credit card number, I was trying to fudge a result by using a previously stored card and changing details around to get a new card to appear. I guess the image was cached with this card result or something, but using a new card shows the generic logo. As with the previous cases, this is because we don't replace whitespace in the card number before trying to match a card network.

Comment 5

[Tim Giles [:tgiles]]

Attachment: Bug 1758369 - Ensure credit card number has no whitespaces or dashes before trying to match type. r=dimi!,sgalich!

This fixes the cases where a website will modify the credit card number after it has been filled.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7b32aee78e60
Ensure credit card number has no whitespaces or dashes before trying to match type. r=dimi,sgalich

Comment 7

[Natalia Csoregi [:nataliaCs]]

Backed out for credit card issues.

• backout: https://hg.mozilla.org/integration/autoland/rev/208be558b119eb707fc3627d2983668f737b2b8c
• push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=7b32aee78e6020b6fd3d8f911da011c4a53518ce
• failure logs:
  • TEST-UNEXPECTED-FAIL | browser/extensions/formautofill/test/browser/creditCard/browser_creditCard_doorhanger.js | at least one notification displayed -
  • TEST-UNEXPECTED-FAIL | org.mozilla.geckoview.test.AutocompleteTest#creditCardSaveModifyAccept | java.lang.AssertionError: Credit card number should match

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/053c8f65df23
Ensure credit card number has no whitespaces or dashes before trying to match type. r=dimi,sgalich

Comment 9

[Sandor Molnar[:smolnar]]

Backed out changeset 053c8f65df23 (bug 1758369) for causing gv-junit failures in geckoview.test.AutocompleteTest#creditCardSaveModifyAccept

Backout link:https://hg.mozilla.org/integration/autoland/rev/3fcbaba555a77534d3524b194e8a48078192b23b

Push with failures

Failure log

INFO -  04-01 19:37:13.876 D/GeckoViewContent( 3486): handleEvent: DOMWindowClose
[task 2022-04-01T19:37:14.059Z] 19:37:14     INFO -  04-01 19:37:13.876 D/GeckoViewConsole( 3486): onEvent GeckoView:WebExtension:List null
[task 2022-04-01T19:37:14.059Z] 19:37:14     INFO -  04-01 19:37:13.877 E/GeckoSessionTestRule( 3486): test_end c5ee677f-bc83-49bd-9e28-2d35f3d0f059 creditCardSaveModifyAccept(org.mozilla.geckoview.test.AutocompleteTest)
[task 2022-04-01T19:37:14.059Z] 19:37:14  WARNING -  TEST-UNEXPECTED-FAIL | org.mozilla.geckoview.test.AutocompleteTest#creditCardSaveModifyAccept | java.lang.AssertionError: Credit card number should match
[task 2022-04-01T19:37:14.059Z] 19:37:14     INFO -  TEST-INFO took 164ms

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee41887d66eb
Ensure credit card number has no whitespaces or dashes before trying to match type. r=dimi,sgalich,geckoview-reviewers,agi

Comment 11

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/ee41887d66eb

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.

Comment 13

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:tgiles, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 14

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

I managed to reproduce this issue on Firefox 100.0(20220428192727) on Ubuntu 20.04. Verified as fixed on Firefox 101.0b4(20220508185621) and Nightly 102.0a1(20220509190429) on Ubuntu 20.04, macOS 11 and Win10 64-bits.