Closed Bug 1758387 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33087 - [@container] Implicit container selection, remove name()/type()

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33087 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33087
Details from upstream follow.

Anders Hartvoll Ruud <andruud@chromium.org> wrote:

[@container] Implicit container selection, remove name()/type()

There was a resolution recently that (nameless) container queries
should automatically evaluate against the nearest container that
supports all the features used in the query. For example, given a
query ((width:1px) and (height:1px)), and supposing that the nearest
container has container-type:inline-size, the query should not fail,
but instead keep searching the ancestor chain for a container with
container-type:size.

This CL implements that behavior, and removes the name() and type()
functions from the @container prelude.

Inspector: Changed FindContainerForElement to accept a
ContainerSelector instead of a name. This is because a real
ContainerSelector is required to get accurate container selection
given the new behavior, and we had a test affected by this.
(The element with class "query-unnamed" will now through implicit
container selection reach beyond the immediate named container, and
query the outer unnamed container, hence that element is marked with
"desc-unnamed").

Fixed: 1300545, 1300547
Change-Id: Ic97ff34ecc1f49caa33940ca1451af21ac94d20b
Reviewed-on: https://chromium-review.googlesource.com/3497355
WPT-Export-Revision: 83446b8bc7cbe9e98d3712b5a02d84e92823800d

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Component: web-platform-tests → Layout
Product: Testing → Core
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 11 subtests

Status Summary

Firefox

ERROR: 4

Chrome

ERROR: 4

Safari

OK : 4
PASS : 35
FAIL : 64

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-contain/container-queries/at-container-parsing.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/container-nested.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/container-selection.html: ERROR (Chrome: ERROR, Safari: OK)
/css/css-contain/container-queries/unsupported-axis.html: ERROR (Chrome: ERROR, Safari: OK)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e21501764b60
[wpt PR 33087] - [@container] Implicit container selection, remove name()/type(), a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7451512d2128
[wpt PR 33087] - [@container] Implicit container selection, remove name()/type(), a=testonly

https://hg.mozilla.org/mozilla-central/rev/7451512d2128

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.