Closed Bug 1758390 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33089 - CloseWatcher: externalize tests

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox100 fixed)

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33089 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33089
Details from upstream follow.

Domenic Denicola <domenic@chromium.org> wrote:

CloseWatcher: externalize tests

Bug: 1171318
Change-Id: Ia21540f33a2d7ee0fb17d5556801888f21869350
Reviewed-on: https://chromium-review.googlesource.com/3507274
WPT-Export-Revision: 1087c3dd3fc45cddca8ca5a45f33221b1adc381b

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 5 subtests

Status Summary

Firefox

OK : 2
FAIL : 25

Chrome

OK : 1
PASS : 5
ERROR: 1

Safari

OK : 2
FAIL : 25

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/close-watcher/basic.html
signalClose() with no user activation only fires close: FAIL (Safari: FAIL)
destroy() then signalClose() fires no events: FAIL (Safari: FAIL)
signalClose() then destroy() fires only one close event: FAIL (Safari: FAIL)
Esc key does not count as user activation, so it fires close but not cancel: FAIL (Safari: FAIL)
destroy() then close via Esc key fires no events: FAIL (Safari: FAIL)
Esc key then destroy() fires only one close event: FAIL (Safari: FAIL)
close via synthesized escape key should not work: FAIL (Safari: FAIL)
Multiple CloseWatchers require a user activation.: FAIL (Safari: FAIL)
Cannot create multiple CloseWatchers from a single user activation: FAIL (Safari: FAIL)
Multiple CloseWatchers work as a stack if secondary watchers are created with a user activation.: FAIL (Safari: FAIL)
3 user activations let you have 3 + 1 = 4 close watchers/0 cancel events: FAIL (Safari: FAIL)
3 user activations let you have 2 close watchers with 1 cancel event, even if the first cancel event is prevented: FAIL (Safari: FAIL)
destroying a free CloseWatcher allows a new one to be created without a user activation.: FAIL (Safari: FAIL)
signalClose()ing a free CloseWatcher allows a new one to be created without a user activation.: FAIL (Safari: FAIL)
Closing a free CloseWatcher via the escape key allows a new one to be created without a user activation.: FAIL (Safari: FAIL)
destroy inside oncancel: FAIL (Safari: FAIL)
destroy inside onclose is benign: FAIL (Safari: FAIL)
signalClose inside oncancel should not trigger an infinite loop: FAIL (Safari: FAIL)
signalClose inside onclose should not trigger an infinite loop: FAIL (Safari: FAIL)
signalClose with events added via addEventListener: FAIL (Safari: FAIL)
/close-watcher/frame-removal.html
detaching the iframe during the cancel event: FAIL (Chrome: PASS, Safari: FAIL)
detaching the iframe during the close event: FAIL (Chrome: PASS, Safari: FAIL)
detaching the iframe then calling destroy(): FAIL (Chrome: PASS, Safari: FAIL)
detaching the iframe then calling signalClose(): FAIL (Chrome: PASS, Safari: FAIL)
detaching the iframe then constructing a CloseWatcher: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5d0120c6d87c
[wpt PR 33089] - CloseWatcher: externalize tests, a=testonly
https://hg.mozilla.org/integration/autoland/rev/0a0218968ff7
[wpt PR 33089] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.