1758395 - [wpt-sync] Sync PR 33090 - CloseWatcher: add AbortSignal integration

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 33090 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33090
Details from upstream follow.

Domenic Denicola <[e-mail]> wrote:

CloseWatcher: add AbortSignal integration

See https://github.com/WICG/close-watcher/pull/16.

Bug: 1171318
Change-Id: I775ff5c1ce443187ed3da7b120d4b626accbb129
Reviewed-on: https://chromium-review.googlesource.com/3507773
WPT-Export-Revision: 8fa4d5d4e6413357ceb14d60563ce13cd6795446

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2033007098b680b65144586f6e1fde6d9e97090

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 9 subtests

Status Summary

Firefox

OK : 1
FAIL: 9

Chrome

OK : 1
FAIL: 9

Safari

OK : 1
FAIL: 9

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/close-watcher/abortsignal.html
already-aborted AbortSignal then close() fires no events: FAIL (Chrome: FAIL, Safari: FAIL)
abortController.abort() then close() fires no events: FAIL (Chrome: FAIL, Safari: FAIL)
close() then abortController.abort() fires only one close event: FAIL (Chrome: FAIL, Safari: FAIL)
already-aborted AbortSignal then Esc key fires no events: FAIL (Chrome: FAIL, Safari: FAIL)
abortController.abort() then close via Esc key fires no events: FAIL (Chrome: FAIL, Safari: FAIL)
Esc key then abortController.abort() fires only one close event: FAIL (Chrome: FAIL, Safari: FAIL)
abortController.abort()ing a free CloseWatcher allows a new one to be created without a user activation: FAIL (Chrome: FAIL, Safari: FAIL)
abortController.abort() inside oncancel: FAIL (Chrome: FAIL, Safari: FAIL)
abortController.abort() inside onclose is benign: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3030cd1becef
[wpt PR 33090] - CloseWatcher: add AbortSignal integration, a=testonly
https://hg.mozilla.org/integration/autoland/rev/b400f39135ec
[wpt PR 33090] - Update wpt metadata, a=testonly

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b99f294c98b7
[wpt PR 33090] - CloseWatcher: add AbortSignal integration, a=testonly
https://hg.mozilla.org/integration/autoland/rev/748dae3d4efb
[wpt PR 33090] - Update wpt metadata, a=testonly

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/b99f294c98b7
https://hg.mozilla.org/mozilla-central/rev/748dae3d4efb