libotr.dll is 11MB
Categories
(Thunderbird :: Build Config, defect, P2)
Tracking
(thunderbird_esr91+ fixed)
People
(Reporter: rjl, Assigned: rjl)
Details
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
wsmwk
:
approval-comm-esr91+
|
Details | Review |
libotr.dll is way too big. Even considering that it's statically linking libgcrypt and libgpg-error, it should not be 11MB. Linux64 is ~1.8MB I would expect the DLL to be about the same.
Assignee | ||
Updated•2 years ago
|
Assignee | ||
Comment 1•2 years ago
|
||
libotr.dll did not have debug symbols stripped prior to packaging due to not
really being integrated into the build. This resulted in Thunderbird shipping
an 11MB libotr.dll file.
Adding the "-s" argument to the link command brings the DLL size down to ~1.5MB
which is in-line with other platforms.
I verified that Linux and macOS builds of libotr do not have debug symbols in
the shipped builds.
Assignee | ||
Updated•2 years ago
|
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/055b8562e8fa
Strip symbols from libotr.dll when linking. r=#thunderbird-reviewers,aleca
Updated•2 years ago
|
Assignee | ||
Comment 3•2 years ago
|
||
Verified on 99.0b1 that libotr.dll
is now ~1.5MB (win64) and that OTR conversations work as expected.
Assignee | ||
Comment 4•2 years ago
|
||
Comment on attachment 9266794 [details]
Bug 1758399 - Strip symbols from libotr.dll when linking. r=#thunderbird-reviewers
[Approval Request Comment]
Regression caused by (bug #):
User impact if declined: No visible impact, just a file that's bigger than necessary.
Testing completed (on c-c, etc.): 99.0b1 verified
Risk to taking this patch (and alternatives if risky): Minimal risk, the change just strips debug symbols from libotr.dll. This would make debugging with that dll harder, but to my knowledge this is not something we are doing a whole lot if at all.
Comment 5•2 years ago
|
||
Comment on attachment 9266794 [details]
Bug 1758399 - Strip symbols from libotr.dll when linking. r=#thunderbird-reviewers
[Triage Comment]
Approved for esr91
Assignee | ||
Comment 6•2 years ago
|
||
bugherder uplift |
Thunderbird 91.8.0:
https://hg.mozilla.org/releases/comm-esr91/rev/a3474c836810
Description
•