Closed Bug 1758415 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33101 - [GridFragmentation] Prevent infinite expansion.

Categories

(Core :: Layout, task, P4)

Product:
Core
Component:
Layout
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33101 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33101
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[GridFragmentation] Prevent infinite expansion.

We allow grid-items to expand their grid-rows under some common
conditions. This is good as it allows text to not overlap, etc.

However when combined with a %-block-size descendant, we might end up
in a situation where we'll loop indefinitely trying to constantly
grow the row to the item. E.g.

\<div style="display: grid;">
\<div style="min-height: 100px;">
\<div style="height: 200%; background: green;">\</div>
\</div>

This patch disables this behaviour by not setting the
MinBlockSizeShouldEncompassIntrinsicSize flag for any grid item with
a %-height-descendant.

Bug: 614667
Change-Id: Ie52b5fb2903259ed92ce6e5cbc5b200a94f088dc

Reviewed-on: https://chromium-review.googlesource.com/3508504
WPT-Export-Revision: bac990f78573ac47043ece14dd7f484907921d29

Component: web-platform-tests → Layout
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

PASS: 1

Safari

PASS: 1

Links

GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/css/css-break/grid/grid-item-infinite-expansion.html: FAIL

New Tests That Don't Pass

/css/css-break/grid/grid-item-infinite-expansion.html: FAIL (Chrome: PASS, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5c500bd6a5c0
[wpt PR 33101] - [GridFragmentation] Prevent infinite expansion., a=testonly
https://hg.mozilla.org/integration/autoland/rev/1b1a7e1049b2
[wpt PR 33101] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2bf8e2424531
[wpt PR 33101] - [GridFragmentation] Prevent infinite expansion., a=testonly
https://hg.mozilla.org/integration/autoland/rev/109afcc2d4c7
[wpt PR 33101] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2bf8e2424531
https://hg.mozilla.org/mozilla-central/rev/109afcc2d4c7

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.