1758476 - Remove some unnecessary uses of the target object argument to ChromeUtils.import

Status: RESOLVED FIXED

(Toolkit :: General, task, P3)

Description

[Mark Banner (:standard8)]

We have various code doing things like:

XPCOMUtils.defineLazyGetter(this, "PageMenuChild", () => {
  let tmp = {};
  ChromeUtils.import("resource://gre/modules/PageMenu.jsm", tmp);
  return new tmp.PageMenuChild();
});

and

let utils = {};
ChromeUtils.import("resource://gre/modules/DownloadUtils.jsm", utils);
let displayHost = utils.DownloadUtils.getURIHost(uri.spec)[0];

Passing as the second argument is now unnecessary, as the exports are also returned from the function.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1758476 - Remove some unnecessary uses of the target object argument to ChromeUtils.import. r?Gijs,Mossop

Depends on D140517

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/528295e7cb0c
Remove some unnecessary uses of the target object argument to ChromeUtils.import. r=mossop,webdriver-reviewers,perftest-reviewers,robwu,whimboo,AlexandruIonescu

Comment 3

[Cristian Tuns]

Backed out for causing tabswitch failures

• Backout link
• Push with failures
• Failure Log

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/124502b05af0
Remove some unnecessary uses of the target object argument to ChromeUtils.import. r=mossop,webdriver-reviewers,perftest-reviewers,robwu,whimboo,AlexandruIonescu

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/124502b05af0