1758481 - Remove the target object argument from ChromeUtils.import

Status: NEW

(Core :: XPConnect, task)

Description

[Mark Banner (:standard8)]

Work has been going on in the dependent bugs to restrict the target argument to ChromeUtils.import from being null, this or {}, and we're now looking at removing the argument altogether.

This will help with moving to ES6 modules, since our imports will be then be only one argument and therefore work with the import system of modules with minimal changes needed.

Comment 1

[Rob Wu [:robwu]]

If the goal is the removal of the second argument altogether, why did the eslint rule from bug 1758474 only check for {} values?

The introduction and enforcement of this check would be easier if you would ban the use of the second parameter, and either fix up all uses or add them to .eslintrc for specific files (marking as warning or turning them off instead of treating them as an error).

Comment 2

[Mark Banner (:standard8)]

(In reply to Rob Wu [:robwu] from comment #1)

If the goal is the removal of the second argument altogether, why did the eslint rule from bug 1758474 only check for {} values?

This is something that we have been working on progressively, where the original aim was just bug 1609271, and these follow-ups only being realised recently. Just having bug 1609271 in itself helps with specific issues that I believe will help work towards es modules move forwards.

The introduction and enforcement of this check would be easier if you would ban the use of the second parameter, and either fix up all uses or add them to .eslintrc for specific files (marking as warning or turning them off instead of treating them as an error).

There are indeed multiple ways that we could roll these remaining parts out / restrict them etc. In this case there's less than about 20 instances where the two-parameter arguments are still used, and I haven't been seeing new cases added, so my concern has been low.

When I filed this, my hope was to have time to go through those last instances and hopefully be able to clean them up and complete this within a few weeks. Then the job would have been done and the second parameter couldn't be used at all. Unfortunately I've just had two weeks of very high priority work which has stopped me getting to this stage.

Comment 3

[Mark Banner (:standard8)]

I have a set of patches that does most of the work here, there's a couple more bits to finish, will probably split up into a few more dependent bugs.

Comment 4

[Mark Banner (:standard8)]

Attachment: WIP: Bug 1758481 - Remove the target object argument from ChromeUtils.import.

Depends on D145659

Comment 5

[Mark Banner (:standard8)]

Unassigning myself until it is time to do this.