Closed
Bug 1758503
Opened 2 years ago
Closed 2 years ago
Add additional tests for AboutWelcome configurable UI
Categories
(Firefox :: Messaging System, enhancement, P1)
Firefox
Messaging System
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
People
(Reporter: mviar, Assigned: mviar)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
This follows up a recent refactor of AboutWelcome.jsx to support configurable Spotlight messages. Additional test coverage would be beneficial, specifically tests in browser_aboutwelcome_configurable_ui.js that:
- Test rendering a screen with title that's fancy, slim, and larger
- Test rendering a screen with an image for a background
- Test rendering a screen with an a text color override (should include ensuring the override persists in dark/light mode)
Additionally, we should add a test to browser_aboutwelcome_rtamo.js checking that the addon name is rendered on the RTAMO screen. Failing to pass the addonName prop in a recent patch resulted in a regression.
|
Assignee | |
Comment 1•2 years ago
|
||
|
|
Assignee | |
Comment 2•2 years ago
|
||
We do have a test for addOn name in the RTAMO flow, but it's not configured to run on Linux (I'm assuming this is why it didn't show up as a failure on the try server).
|
||
Updated•2 years ago
|
Attachment #9266870 -
Attachment description: WIP: Bug 1758503 - Add additional tests for AboutWelcome configurable UI → Bug 1758503 - Add additional tests for AboutWelcome configurable UI
|
||
Updated•2 years ago
|
Iteration: --- → 99.2 - Feb 21 - Mar 6
Priority: -- → P1
|
|
Assignee | |
Updated•2 years ago
|
Assignee: nobody → mviar
|
|
||
Updated•2 years ago
|
Attachment #9266870 -
Attachment description: Bug 1758503 - Add additional tests for AboutWelcome configurable UI → WIP: Bug 1758503 - Add additional tests for AboutWelcome configurable UI
|
|
||
Updated•2 years ago
|
Attachment #9266870 -
Attachment description: WIP: Bug 1758503 - Add additional tests for AboutWelcome configurable UI → Bug 1758503 - Add additional tests for AboutWelcome configurable UI
|
||
Updated•2 years ago
|
Iteration: 99.2 - Feb 21 - Mar 6 → 100.1 - March 1 - March 18
Pushed by mviar@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/07b65031aeab Add additional tests for AboutWelcome configurable UI r=Mardak,emcminn
|
||
Comment 4•2 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox100:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•