Closed Bug 1758524 Opened 1 year ago Closed 11 months ago

Implement the HTTP priority incremental flag

Categories

(Core :: Networking: HTTP, task, P2)

Product:
Core
Component:
Networking: HTTP
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
101 Branch
Tracking Flags:
Tracking Status
firefox101 --- fixed

People

(Reporter: dragana, Assigned: edgul)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

(Whiteboard: [necko-triaged])

Attachments

(2 files)

Bug 1758524 (WIP) - Implement http priority flag
48 bytes, text/x-phabricator-request
Details | Review
Bug 1758524 (WIP) - Implement the http priority incremental flag: added lint fixes and test coverage. Differential Revision: https://phabricator.services.mozilla.com/D142694
48 bytes, text/x-phabricator-request
Details | Review

HTTP/3 (also the new HTTP/2) priority draft introduces "Incremental" flag.

In necko code, we currently do not have the information needed to decide whether to set that flag. We will need to extend the necko API to set the flag.

Background info:

  • class of services flags
  • HttpChannelBase implements nsIClassOfService that has methods setClassOfService
  • this where the priorities is propagated into neqo.

We need to extend nsIClassOfService to add the "incremental" flag.

Assignee: nobody → eguloien
Status: NEW → ASSIGNED
Attachment #9270440 - Attachment description: WIP: Bug 1758524 (WIP) - Implement http priority flag → Bug 1758524 (WIP) - Implement http priority flag
Attachment #9270915 - Attachment description: WIP: Bug 1758524 (WIP) - Implement the http priority incremental flag: added some lint fixes. Differential Revision: https://phabricator.services.mozilla.com/D142694 → Bug 1758524 (WIP) - Implement the http priority incremental flag: added lint fixes and test coverage. Differential Revision: https://phabricator.services.mozilla.com/D142694
Pushed by eguloien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e65d3214649e
(WIP) - Implement http priority flag r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/b0abbd5936af
(WIP) - Implement the http priority incremental flag: added lint fixes and test coverage. Differential Revision: https://phabricator.services.mozilla.com/D142694 r=necko-reviewers,dragana

Backed out for causing xpcshell failures in test_http3_prio_disabled_wrap.js

Flags: needinfo?(eguloien)

Latest testing failure appears to be from https://bugzilla.mozilla.org/show_bug.cgi?id=1760125

Depends on: 1760125
Flags: needinfo?(eguloien)
Pushed by eguloien@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3b8ae696d08d
(WIP) - Implement http priority flag r=necko-reviewers,dragana
https://hg.mozilla.org/integration/autoland/rev/3899920ef9f1
(WIP) - Implement the http priority incremental flag: added lint fixes and test coverage. Differential Revision: https://phabricator.services.mozilla.com/D142694 r=necko-reviewers,dragana
Regressions: 1767108
Regressions: 1767115
Regressions: 1767116
Regressions: 1767117

https://hg.mozilla.org/mozilla-central/rev/3b8ae696d08d
https://hg.mozilla.org/mozilla-central/rev/3899920ef9f1

Status: ASSIGNED → RESOLVED
Closed: 11 months ago
status-firefox101: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 101 Branch

Just reiterating here that the test failures that appear to be caused by this implementation are very likely caused by a known issue in the http3 test server, documented here https://bugzilla.mozilla.org/show_bug.cgi?id=1760125.

These appear new because the previously used netwerk/test/unit/test_http3_prio.js was extended into the following tests:

  • netwerk/test/unit/test_http3_prio_enabled.js
  • netwerk/test/unit/test_http3_prio_disabled.js
  • netwerk/test/unit_ipc/test_http3_prio_enabled_wrap.js
  • netwerk/test/unit_ipc/test_http3_prio_disabled_wrap.js
You need to log in before you can comment on or make changes to this bug.