Closed Bug 1758608 Opened 2 years ago Closed 2 years ago

Enable some Objective-C/C++ diagnostics that are currently warning-free

Categories

(Core :: Widget: Cocoa, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox-esr91 --- wontfix
firefox98 --- wontfix
firefox99 --- wontfix
firefox100 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Only enable them when building on macOS or cross-compiling for macOS on Linux.

catch redeclaration of ObjC method parameter name
-Wduplicate-method-arg

catch multiple declarations of ObjC method found
-Wduplicate-method-match

catch ObjC method with no return type specified
-Wmissing-method-return-type

catch implicit conversions between ObjC BOOL and int
-Wobjc-signed-char-bool

catch semicolon before ObjC method body
-Wsemicolon-before-method-body

catch ObjC method parameter type not matching super class method
-Wsuper-class-method-mismatch

https://clang.llvm.org/docs/DiagnosticsReference.html

Only enable them when building on macOS or cross-compiling for macOS on Linux.

catch redeclaration of ObjC method parameter name
-Wduplicate-method-arg

catch multiple declarations of ObjC method found
-Wduplicate-method-match

catch ObjC method with no return type specified
-Wmissing-method-return-type

catch implicit conversions between ObjC BOOL and int
-Wobjc-signed-char-bool

catch semicolon before ObjC method body
-Wsemicolon-before-method-body

catch ObjC method parameter type not matching super class method
-Wsuper-class-method-mismatch

https://clang.llvm.org/docs/DiagnosticsReference.html

Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/35cd76f6b7bf
Enable some Objective-C/C++ diagnostics that are currently warning-free. r=firefox-build-system-reviewers,andi
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.