1758624 - ObjectActor#_populateGripPreview could be faster

Status: RESOLVED FIXED

(DevTools :: Console, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

Logging an object shows that extra time is spent in unrelated previewers functions (Error, ArrayLike, …). There should be room for improvement here

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1758624 - [devtools] Make Object previewers faster. r=bomsy.

Accessing DebuggerObject.class is showing up in profile as it's a getter; since
we pass the grip to the previewers, and given we put a class property on the
grip, we can query that property instead in previewers to avoid calling the
getter.
We also don't use object destructuring in some function signatures as it's
doing extra work we might end up not needing if the previewer isn't the one
that should be used for the object.

Depends on D139570

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4eb9bf9760a
[devtools] Make Object previewers faster. r=bomsy.

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/c4eb9bf9760a