1758625 - Don't retrieve/include ownSymbols and privateProperties when they wouldn't be used

Status: RESOLVED FIXED

(DevTools :: Console, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

We're always fetching the private properties and symbols (devtools/server/actors/object/previewers.js#493-500) even if we might not use it (if we have more "regular" properties than OBJECT_PREVIEW_MAX_ITEMS).

We could delay retrieving those to when we actually need them.

In a similar fashion, we may want to not include the related properties if they would be empty, as the client should be handling that perfectly, and it would save some time for the JSActor communication

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1758625 - [devtools] Only include ownSymbols(Length)/privateProperties(Length) in grip when there are some in the object. r=ochameau.

This should help save some cycle in JSActor communication when logging objects.
The client handles those propery only when they are not falsy, so we don't need
to do anything there with this change.

Depends on D140603

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79c696ca8002
[devtools] Only include ownSymbols(Length)/privateProperties(Length) in grip when there are some in the object. r=ochameau.

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/79c696ca8002