1758634 - An early quit/restart while Firefox hasn't been finished initialization can trigger crashes

Status: NEW

(Testing :: Marionette Client and Harness, defect, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As seen while working on bug 1726465 an early quit/shutdown as triggered by Marionette can cause crashes of the browser. We have seen similar things in the past but so far haven't thought about delaying the actual shutdown until initialization has been finished.

While taking a look at the quitter extension today I noticed the following code:

https://searchfox.org/mozilla-central/rev/131f3af9a49d2203adb7b7ef30dcc37c9f1aa10b/tools/quitter/parent.js#18

          if (browserWindow && browserWindow.gBrowserInit) {
            await browserWindow.gBrowserInit.idleTasksFinishedPromise;
          }

As such before calling Services.app.quit() we should run the above code and make sure that all open browser windows have finished their idle tasks.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

As discussed we will not focus on this bug yet given that a browser window is still needed.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:whimboo, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Lets actually revisit if it's really needed after bug 1726465 has been fixed.

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

We still have certain situations when an early shutdown can cause a hang of Firefox. Lets get those added as dependencies.

Also there is bug 1745430 which covers possible test scenarios with Marionette to trigger these crashes.