1758638 - ConsoleAPIListener#isMessageRelevant could be faster

Status: RESOLVED FIXED

(DevTools :: Console, task)

Description

[Nicolas Chevobbe [:nchevobbe]]

In this profile: https://share.firefox.dev/3hUWJAx , 3.5% of console.log is spent in isMessageRelevant.
Most of the time there is spent retrieving the innerWindowId of the instance window, which we can probably cache
The other part is spent in getWorkerType which may be sped up by not looking into the array of worker ids.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

DAMP results aren't super obvious (perfherder), but this is not showing up in profile anymore.
Also, the content-process-bulklog test logs window/objects and most of the time is spent creating the grip, but I guess this patch would help more in places where we only log primitives.

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1758638 - [devtools] Speedup ConsoleAPIListener#isMessageRelevant. r=jdescottes.

Store the window innerWindowId instead of retrieving it for each message.
Refactor getWorkerType to not use Array method.

Depends on D140604

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/14aa2e66826f
[devtools] Speedup ConsoleAPIListener#isMessageRelevant. r=jdescottes.

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/14aa2e66826f