1758652 - 3.72% cnn-nav.world dcf (OSX) regression on Fri January 14 2022

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Alex Finder]

Perfherder has detected a browsertime performance regression from push eb80fdfd96b6294b60f6617a9ffc8aa1d3334e77. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
34%	cnn-nav.world FirstVisualChange	macosx1015-64-shippable-qr	cold fission webrender	273.57 -> 367.06
26%	cnn-nav.world SpeedIndex	macosx1015-64-shippable-qr	cold fission webrender	333.63 -> 419.74

Improvements:

Ratio	Test	Platform	Options	Absolute values (old vs new)
4%	cnn-nav.world dcf	macosx1015-64-shippable-qr	cold fission webrender	440.29 -> 423.92
4%	cnn-nav.world fcp	macosx1015-64-shippable-qr	cold fission webrender	430.23 -> 414.67

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the offending patch(es) will be backed out in accordance with our regression policy.

For more information on performance sheriffing please see our FAQ.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1748341

Comment 2

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

I'm looking into this, but I have a number of other things I'm also dealing with. In the meantime, this is important functionality and we don't want to back it out. Additionally, looking at the measurements collected, the affected tests have a considerable margin of error.

Comment 3

[Dianna Smith [:diannaS]]

:keeler any update on this?

Comment 4

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Attachment: Bug 1758652 - avoid creating CERTCertificates in IsCertBuiltInRoot, rework saving intermediates r?jschanck

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

I'm hoping this patch will improve things.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ce0cae091ff
avoid creating CERTCertificates in IsCertBuiltInRoot, rework saving intermediates r=jschanck

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/5ce0cae091ff

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:keeler, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 9

[Dana Keeler (she/her) (use needinfo) [:keeler] (on leave)]

Given that 98 and 99 already shipped with this, I don't think we need to uplift.