Closed Bug 1758695 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33117 - Filter out other service workers in getRegistrations() WPT

Categories

(Core :: DOM: Service Workers, task, P4)

Product:
Core
Component:
DOM: Service Workers
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33117 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33117
Details from upstream follow.

Steven Bingler <bingler@chromium.org> wrote:

Filter out other service workers in getRegistrations() WPT

partitioned-service-worker-getRegistrations.tentative.https.html was
consistently timing out on wpt.fyi but worked fine for local runs.

It turned out that an earlier test would also time out and leave
behind its own service worker registration. Since
getRegistrations() returns all SWs on an origin it would return >1
when the test was expecting exactly 1 which would lead to the timeout.

This CL works around that by filtering out all SWs registrations that
do not match the intended scope.

This CL also fixes a small issue where the path to a script was
incorrect.

Bug: 1246549
Change-Id: I0263e15fc37a2a5af947f1a37d2f9b3d3f13940e

Reviewed-on: https://chromium-review.googlesource.com/3510190
WPT-Export-Revision: b762a18e8fe9041f36f1a34eccf34a72648373e9

Component: web-platform-tests → DOM: Service Workers
Product: Testing → Core
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 1 subtests

Status Summary

Firefox

OK : 4
PASS: 3
FAIL: 1[Gecko-linux1804-64-domstreams-qr-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub] 4[Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview]

Chrome

OK : 4
FAIL: 4

Safari

OK : 4
PASS: 3
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/service-workers/service-worker/partitioned-service-worker-claim.tentative.https.html
ServiceWorker's clients.claim() is partitioned: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], PASS [Gecko-linux1804-64-domstreams-qr-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub] (Chrome: FAIL, Safari: PASS)
/service-workers/service-worker/partitioned-service-worker-getRegistrations.tentative.https.html
ServiceWorker's getRegistrations() is partitioned: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], PASS [Gecko-linux1804-64-domstreams-qr-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub] (Chrome: FAIL, Safari: PASS)
/service-workers/service-worker/partitioned-service-worker-matchAll.tentative.https.html
ServiceWorker's matchAll() is partitioned: FAIL (Chrome: FAIL, Safari: FAIL)
/service-workers/service-worker/partitioned-service-worker.tentative.https.html
Services workers under different top-level sites are partitioned.: FAIL [Gecko-android-em-7.0-x86_64-lite-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview], PASS [Gecko-linux1804-64-domstreams-qr-debug, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-qr-opt, Gecko-windows10-32-2004-qr-debug, Gecko-windows10-32-2004-qr-opt, Gecko-windows10-64-2004-qr-debug, Gecko-windows10-64-2004-qr-opt, GitHub] (Chrome: FAIL, Safari: PASS)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/4aa650528c7f
[wpt PR 33117] - Filter out other service workers in getRegistrations() WPT, a=testonly
https://hg.mozilla.org/integration/autoland/rev/dc97792756ee
[wpt PR 33117] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8bc642ab939a
[wpt PR 33117] - Filter out other service workers in getRegistrations() WPT, a=testonly
https://hg.mozilla.org/integration/autoland/rev/2e8c2fad28b3
[wpt PR 33117] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/8bc642ab939a
https://hg.mozilla.org/mozilla-central/rev/2e8c2fad28b3

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
Regressions: 1761683
You need to log in before you can comment on or make changes to this bug.