1758702 - Including WorkerPrivate.h requires local includes from dom/workers.

Status: RESOLVED FIXED

(Core :: DOM: Workers, task)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1758702 - Allow ThreadSafeWeakPtr<IncompleteType> to work. r=nika

This will be used to avoid problematic includes from WorkerPrivate.h,
and it matches the behavior of RefPtr<> and WeakPtr<>.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1758702 - Avoid including RemoteWorkerChild in WorkerPrivate.h. r=asuth

This avoids having to include PRemoteBrowser* headers etc, which are not
exported otherwise.

Depends on D140658

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66625baf0875
Allow ThreadSafeWeakPtr<IncompleteType> to work. r=glandium
https://hg.mozilla.org/integration/autoland/rev/3e00d9203851
Avoid including RemoteWorkerChild in WorkerPrivate.h. r=asuth

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

Backed out for causing build bustages. CLOSED TREE

Backout link : https://hg.mozilla.org/integration/autoland/rev/39a4165e5dc674290eab8f2385f2a156214a5a99

Push with failures : https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Crunnable&revision=3e00d9203851e80e69a4a18a136debc9a38654a2&selectedTaskRun=B0f8niYzSE6pThOpC8G_uA.0

Link to failure log :
https://treeherder.mozilla.org/logviewer?job_id=371386545&repo=autoland&lineNumber=9575
https://treeherder.mozilla.org/logviewer?job_id=371386588&repo=autoland&lineNumber=11826
https://treeherder.mozilla.org/logviewer?job_id=371386819&repo=autoland&lineNumber=13232
https://treeherder.mozilla.org/logviewer?job_id=371386780&repo=autoland&lineNumber=11558

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/93dfc5ec7290
Allow ThreadSafeWeakPtr<IncompleteType> to work. r=glandium

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2195d169b6c8
Avoid including RemoteWorkerChild in WorkerPrivate.h. r=asuth

Comment 7

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/93dfc5ec7290

Comment 8

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/2195d169b6c8