1758729 - Live language Search switch Wikipedia localized engine is not switched

Status: VERIFIED FIXED

(Firefox :: Search, defect, P2)

Description

[Adrian Florinescu [:aflorinescu]]

[Description:]

Wikipedia has most engines localized, live switching requires the localized wikipedia engines to be changed.

[Environment:]

99.0b1 (2022-03-09)
100.0a1 (2022-03-09)

Mac 11
Windows 10

[Preconditions:]

user_pref("intl.multilingual.downloadEnabled", true);
user_pref("intl.multilingual.enabled", true);
user_pref("intl.multilingual.liveReload", true);
Install:
language-pack zh-cn
language-pack ca

[Steps:]

1. Install a firefox Firefox locale, en-us for example (autoset region not that relevant).
2. Install language packs from the preconditions.
3. Open about:preferences / Language.
4. Switch the language to zh-cn.
5. Open a new tab with about:preferences / search and check engines
6. Open new tab and try to search using the wikipedia engine.

[Actual Result:]

5. Engines are shown correctly with zh-cn localization applied
6. The search cannot be completed, en.wikipedia is removed but not replaced with cn.wikipedia (TypeError: can't access property "getSubmission", engine is null)

[Expected Result:]

5. Engines are shown correctly with zh-cn localization applied
6. before_language _switch_wikipedia is swapped with the after_language_switch_wikipedia.

[Regression Range:]

Not a regression.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1758729 - Ensure search engines loading different locales from WebExtension are correctly loaded when reloading engines. r?mcheang!,jteow!

The add-on manager may not have updated the default locale for the WebExtension, so we need to ensure we get the correct default locale.
Also correct the check for testing if the name is different to the existing engine.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d6cd1fa1e633
Ensure search engines loading different locales from WebExtension are correctly loaded when reloading engines. r=mcheang,jteow

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d6cd1fa1e633

Comment 4

[Adrian Florinescu [:aflorinescu]]

Verified as fixed on Firefox 100.0b1 with Mac 11 and Windows 10.