1758739 - Calendar doesn't respect "Date and Time Formatting" date format

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Richard Marti (:Paenglab)]

I use a en-US Daily. In the settings I can set underDate and Time Formatting if I want the Application locale or the Regional settings locale. TB follows on all elements this setting. Only Calendar stays on the en-US date with AM/PM.

Comment 1

[Rachel Martin]

TB 91 seems to work correctly. Alice, can you find a regression range here? Just use TB on a non-en-US system and check how the dates are displayed. In the calendar I see "AM/PM" being used which is not the case elsewhere in the UI.

Comment 2

[Henry Wilkes (they/them) [:henry-x]]

Might be bug 1752130

Comment 3

[Alice0775 White]

Regression window:
https://hg.mozilla.org/comm-central/pushloghtml?fromchange=cb7d30458f015c912dba6b2df00d0eca892d2dd7&tochange=ad3ce437ca0d810c077628ea08d50f2afda8b5d6
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=4937cd54a336deaa0d1e44e21a310f3fbd863a76&tochange=ddc6b48554dc442c7eaf9b87e13e58ecc9485b16

Comment 4

[Rachel Martin]

Overall the fix for bug 1752130 appears to be wrong and should just be backed out. Dates/Times are formatted according to the Application Locale or Regional Settings Locale depending on which setting is chosen. Strings in the UI are taken from the application Locale. So if the user uses an English version of TB and regional settings for French, then unavoidably there will be "Day" together with "février" ("February"). Apparently the wording in the date picker/matrix follows the application locale showing "February".

The idea behind the design was that people can use an en-US version of the application and at the same time enjoy their local date/time formatting, for example according to en-AU or en-GB rules.

Comment 5

[Wayne Mery (:wsmwk)]

proactively assigning

Comment 6

[Rachel Martin]

https://github.com/Betterbird/thunderbird-patches/blob/main/102/bugs/backout-bug-1752130-for-causing-bug-1758739-date-format.patch
Not a straight backout since bug 1749011 got in the way on calDateTimeFormatter.jsm. BTW, bug 1749011 should be closed, otherwise it will wait for bug 1749459 (P3/S3) for a long time.

Comment 8

[Ben Bucksch (:BenB)]

Even if I speak US English fluently, and 80% of my conversations are in English, I absolutely cannot deal with the US English date and time formats. It's not just the inversion of date and month, but also the AM/PM thing. In Europe, we're on 24:00 clocks, and I just cannot deal with AM/PM notation, nor with a different date format.

Date/time formatting needs to be choosable separate from language. Many users around the world use the en-US builds, so this is a problem for all of them.

Given that the problem is just in one place, this seems like a straight-forward bug.

Comment 9

[meso5]

(In reply to Ben Bucksch (:BenB) from comment #8)

It's not just the inversion of date and month,

This is more than about inconvenience and annoyance. When I see 7/3/2022 my mind will always interpret it as 7 March. Without context and some extra thinking this will sometimes have very bad consequences, like missed appointments. I am only adding this because someone used to en-US may be wondering what all this fuss is about.

Comment 10

[newsfan]

Why this discussion? For years now you could choose date/time formatting to follow the Application locale or the Regional settings locale. Everyone was happy, apart from the reporter of bug 1752130 who apparently didn't know about the option and was experiencing an English/French mix with application locale English and Regional settings French. They should have just selected Application locale for the display if they wanted consistent English.

It's unclear why bug 1752130 made the change it did destroying the carefully implemented choice between the two display options and leaving the application in an inconsistent state. The date/time display, for example, in the message list/thread pane still follows the user choice as to all other dates within the UI apart for the now broken calendar. That change just needs to be reversed. If you look at comment #6, that fork has already restored the original state.

Comment 11

[Geoff Lankow (:darktrojan)]

Okay, yeah, this is dumb but it doesn't need several people repeating the same information.

Comment 12

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1758739 - Back out changes of bug 1752130. r=#thunderbird-reviewers

Essentially a backout of https://hg.mozilla.org/comm-central/rev/28f648f37dd1 which I never should've wasted my time on in the first place.

Comment 13

[Ben Bucksch (:BenB)]

Thanks, Geoff! r=BenB, FWIW

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2ee5a46c3f61
Back out changes of bug 1752130. r=#thunderbird-reviewers,BenB

Comment 16

[Geoff Lankow (:darktrojan)]

Comment on attachment 9284415 [details]
Bug 1758739 - Back out changes of bug 1752130. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1752130
User impact if declined: Users get strings in the application language whether they want them or not
Testing completed (on c-c, etc.): 6 days
Risk to taking this patch (and alternatives if risky): This is just the old behaviour, so no.

Comment 18

[Wayne Mery (:wsmwk)]

Comment on attachment 9284415 [details]
Bug 1758739 - Back out changes of bug 1752130. r=#thunderbird-reviewers

[Triage Comment]
Approved for beta

Comment 19

[Rob Lemley [:rjl]]

Thunderbird 103.0b6:
https://hg.mozilla.org/releases/comm-beta/rev/3a0d84e16b12

Comment 20

[Geoff Lankow (:darktrojan)]

Comment on attachment 9284415 [details]
Bug 1758739 - Back out changes of bug 1752130. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): bug 1752130
User impact if declined: Users get strings in the application language whether they want them or not
Testing completed (on c-c, etc.): In 103 b6
Risk to taking this patch (and alternatives if risky): This is just the old behaviour, so no.

Comment 21

[Wayne Mery (:wsmwk)]

Comment on attachment 9284415 [details]
Bug 1758739 - Back out changes of bug 1752130. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr102

Comment 22

[Rob Lemley [:rjl]]

Thunderbird 102.1.1:
https://hg.mozilla.org/releases/comm-esr102/rev/e457ecf5df66