1758757 - Remove two ReflowInput::ApplyRelativePositioning methods that require ReflowInput instance

Status: RESOLVED FIXED

(Core :: Layout, task)

Description

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Almost all frame containers who need to place its children in relative positioning use the static ApplyRelativePositioning methods. For the two methods that require ReflowInput instance, the physical-coordinate one [1] is unused, and the logical one [2] is used only by nsTableRowGroupFrame [3].

Let's convert [3] to call [2] instead, and remove [1] and [2] to reduce the API variants from 4 down to 2.

[1] https://searchfox.org/mozilla-central/rev/eeeba8183d3268e0d563c2becf9f4adc21a37368/layout/generic/ReflowInput.h#857-859
[2] https://searchfox.org/mozilla-central/rev/eeeba8183d3268e0d563c2becf9f4adc21a37368/layout/generic/ReflowInput.h#866-871
[3] https://searchfox.org/mozilla-central/rev/eeeba8183d3268e0d563c2becf9f4adc21a37368/layout/tables/nsTableRowGroupFrame.cpp#933-934

Comment 1

[Ting-Yu Lin [:TYLin] (PDT, UTC-7)]

Attachment: Bug 1758757 - Remove two ReflowInput::ApplyRelativePositioning methods that require ReflowInput instance. r?#layout

See bug 1758757 comment 0 for the rationale.

Note: the old code in nsTableRowGroupFrame::SlideChild() is bogus because it
calls ApplyRelativePositioning() via the nsTableRowGroupFrame's ReflowInput
instance. That is, it applies relative positioning to nsTableRowGroupFrame, but
not to the aKidFrame (nsTableRowFrame).

While I'm here, I expand SlideChild in its only caller, and simplify it.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ae2c08e94765
Remove two ReflowInput::ApplyRelativePositioning methods that require ReflowInput instance. r=emilio

Comment 3

[bszekely]

https://hg.mozilla.org/mozilla-central/rev/ae2c08e94765