1758768 - Frequent Windows debug devtools/client/inspector/rules/test/browser_rules_user-property-reset.js | leaked 2 window(s) until shutdown [url = about:devtools-toolbox]

Status: RESOLVED FIXED

(DevTools :: Inspector: Rules, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: imoraru [at] mozilla.com
Parsed log: https://treeherder.mozilla.org/logviewer?job_id=370431958&repo=autoland
Full log: https://firefox-ci-tc.services.mozilla.com/api/queue/v1/task/Mux6LD-_RjikOPKVAqNp1Q/runs/0/artifacts/public/logs/live_backing.log

---

[task 2022-03-09T16:42:48.722Z] 16:42:48     INFO - TEST-START | devtools/client/inspector/rules/test/browser_rules_user-property-reset.js
[task 2022-03-09T16:42:48.732Z] 16:42:48     INFO - GECKO(1120) | [Child 7992, Main Thread] WARNING: IPC message 'PIdleScheduler::Msg_DoneGC' discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:506
[task 2022-03-09T16:42:48.745Z] 16:42:48     INFO - GECKO(1120) | [Child 8164: Main Thread]: I/DocShellAndDOMWindowLeak ++DOCSHELL 21fcde08400 == 1 [pid = 8164] [id = 102]
[task 2022-03-09T16:42:48.747Z] 16:42:48     INFO - GECKO(1120) | [Child 8164: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 1 (21fc8c69430) [pid = 8164] [serial = 312] [outer = 0]
[task 2022-03-09T16:42:48.748Z] 16:42:48     INFO - GECKO(1120) | [Child 8164: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 2 (21fcde08c00) [pid = 8164] [serial = 313] [outer = 21fc8c69430]
[task 2022-03-09T16:42:48.776Z] 16:42:48     INFO - GECKO(1120) | [Child 7992: Main Thread]: I/DocShellAndDOMWindowLeak --DOCSHELL 1cef2606000 == 0 [pid = 7992] [id = 0] [url = http://example.com/browser/devtools/client/inspector/rules/test/doc_author-sheet.html]
[task 2022-03-09T16:42:48.794Z] 16:42:48     INFO - GECKO(1120) | [Child 8164: Main Thread]: I/DocShellAndDOMWindowLeak ++DOMWINDOW == 3 (21fcde14400) [pid = 8164] [serial = 314] [outer = 21fc8c69430]
[task 2022-03-09T16:42:48.814Z] 16:42:48     INFO - GECKO(1120) | [Child 7992, Main Thread] WARNING: IPC message 'PIdleScheduler::Msg_StartedGC' discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:506
[task 2022-03-09T16:42:48.842Z] 16:42:48     INFO - GECKO(1120) | [Child 7992, Main Thread] WARNING: IPC message 'PIdleScheduler::Msg_DoneGC' discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:506
[task 2022-03-09T16:42:48.851Z] 16:42:48     INFO - GECKO(1120) | [Child 7992: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 2 (1ceed467430) [pid = 7992] [serial = 1] [outer = 0] [url = http://example.com/browser/devtools/client/inspector/rules/test/doc_author-sheet.html]
[task 2022-03-09T16:42:48.852Z] 16:42:48     INFO - GECKO(1120) | [Child 7992: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 1 (1cef260b800) [pid = 7992] [serial = 2] [outer = 0] [url = about:blank]
[task 2022-03-09T16:42:48.852Z] 16:42:48     INFO - GECKO(1120) | [Child 7992: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (1cef260e000) [pid = 7992] [serial = 3] [outer = 0] [url = http://example.com/browser/devtools/client/inspector/rules/test/doc_author-sheet.html]
[task 2022-03-09T16:42:48.861Z] 16:42:48     INFO - GECKO(1120) | [Child 7992, Main Thread] WARNING: IPC message 'PIdleScheduler::Msg_StartedGC' discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:506
[task 2022-03-09T16:42:48.867Z] 16:42:48     INFO - GECKO(1120) | [Child 7992, Main Thread] WARNING: IPC message 'PIdleScheduler::Msg_DoneGC' discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:506
[task 2022-03-09T16:42:48.871Z] 16:42:48     INFO - GECKO(1120) | [Child 7992, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp:3359
[task 2022-03-09T16:42:48.874Z] 16:42:48     INFO - GECKO(1120) | [2022-03-09T16:42:48Z WARN  audioipc2::ipccore] AudioIPC Server RPC: EventLoop drop - closing connection for Token(7) failed: Custom { kind: NotFound, error: "I/O source not registered with `Registry`" }
[task 2022-03-09T16:42:48.874Z] 16:42:48     INFO - GECKO(1120) | [Child 7992, Main Thread] WARNING: IPC message 'PIdleScheduler::Msg_StartedGC' discarded: actor cannot send: file /builds/worker/checkouts/gecko/ipc/glue/ProtocolUtils.cpp:506
<...>
[task 2022-03-09T16:42:58.438Z] 16:42:58     INFO - GECKO(1120) | [Parent 8336: Main Thread]: I/DocShellAndDOMWindowLeak --DOMWINDOW == 0 (21848912800) [pid = 8336] [serial = 1017] [outer = 0] [url = about:blank]
[task 2022-03-09T16:42:58.453Z] 16:42:58     INFO - GECKO(1120) | [Parent 8336, Main Thread] WARNING: Extra shutdown CC: 'i < NORMAL_SHUTDOWN_COLLECTIONS', file /builds/worker/checkouts/gecko/xpcom/base/nsCycleCollector.cpp:3359
[task 2022-03-09T16:42:58.525Z] 16:42:58     INFO - GECKO(1120) | [Parent 8336, Main Thread] WARNING: NS_ENSURE_TRUE(Preferences::InitStaticMembers()) failed: file /builds/worker/checkouts/gecko/modules/libpref/Preferences.cpp:4470
[task 2022-03-09T16:42:58.555Z] 16:42:58     INFO - TEST-INFO | Main app process: exit 0
[task 2022-03-09T16:42:58.556Z] 16:42:58     INFO - TEST-INFO | Confirming we saw 731 DOCSHELL created and 731 destroyed log strings.
[task 2022-03-09T16:42:58.556Z] 16:42:58     INFO - TEST-INFO | Confirming we saw 1766 DOMWINDOW created and 1766 destroyed log strings.
[task 2022-03-09T16:42:58.557Z] 16:42:58    ERROR - TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_user-property-reset.js | leaked 2 window(s) until shutdown [url = about:devtools-toolbox]
[task 2022-03-09T16:42:58.557Z] 16:42:58    ERROR - TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_user-property-reset.js | leaked 1 window(s) until shutdown [url = about:blank]
[task 2022-03-09T16:42:58.557Z] 16:42:58    ERROR - TEST-UNEXPECTED-FAIL | devtools/client/inspector/rules/test/browser_rules_user-property-reset.js | leaked 1 window(s) until shutdown [url = chrome://devtools/content/inspector/index.xhtml]
[task 2022-03-09T16:42:58.558Z] 16:42:58     INFO - TEST-INFO | devtools/client/inspector/rules/test/browser_rules_user-property-reset.js | windows(s) leaked: [pid = 8336] [serial = 1017], [pid = 8336] [serial = 1015], [pid = 8336] [serial = 1013], [pid = 8336] [serial = 1016]
[task 2022-03-09T16:42:58.558Z] 16:42:58     INFO - TEST-INFO | devtools/client/inspector/rules/test/browser_rules_user-property-reset.js | This test created 1 hidden window(s)

Comment 1

[Iulian Moraru]

Backfill range and retriggers this shows that Bug 1757193 is the culprit for this. But it doesn't really look like it could be the culprit from the files that it changed.
Mark, can you please take a look at this. Thank you!

Comment 2

[Mark Banner (:standard8)]

(In reply to Iulian Moraru from comment #1)

Backfill range and retriggers this shows that Bug 1757193 is the culprit for this. But it doesn't really look like it could be the culprit from the files that it changed.

The code there is disabled by default so it would be very hard for it to impact anything else, and as you say, it also isn't related to the inspect, so I think that's showing the wrong thing. Maybe it is older? or possibly timing related and didn't show up as much before?

Comment 3

[Iulian Moraru]

Hi Hubert! Could this be caused by your changes from Bug 1740202?
This is the backfill range and retriggers I know that it points to Bug 1757193 but your changes look more related to the issue.

Comment 4

[Intermittent Failures Robot]

29 failures in 2837 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

This is the #44 most frequent failure this week.

Repository breakdown:

• autoland: 22
• mozilla-central: 7

Platform and build breakdown:

• windows10-64-2004-qr: 29
  • debug: 29

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1758768&startday=2022-03-07&endday=2022-03-13&tree=all

Comment 5

[Intermittent Failures Robot]

32 failures in 3304 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

This is the #41 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 23
• mozilla-central: 7
• try: 2

Platform and build breakdown:

• windows10-64-2004-qr: 31
  • debug: 31
• linux1804-64-qr: 1
  • opt: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1758768&startday=2022-03-14&endday=2022-03-20&tree=all

Comment 6

[Julian Descottes [:jdescottes]]

Bomsy will take a look, we can skip on windows debug if no solution is found

Comment 7

[Intermittent Failures Robot]

23 failures in 3341 pushes (0.007 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• autoland: 17
• mozilla-central: 6

Platform and build breakdown:

• windows10-64-2004-qr: 23
  • debug: 23

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1758768&startday=2022-03-21&endday=2022-03-27&tree=all

Comment 8

[Intermittent Failures Robot]

33 failures in 3323 pushes (0.01 failures/push) were associated with this bug in the last 7 days.

This is the #25 most frequent failure this week.

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. **

Repository breakdown:

• autoland: 23
• mozilla-central: 10

Platform and build breakdown:

• windows10-64-2004-qr: 33
  • debug: 33

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1758768&startday=2022-03-28&endday=2022-04-03&tree=all

Comment 9

[Julian Descottes [:jdescottes]]

There is really nothing odd about this test, and the logs also don't show anything interesting.
This is the last test from devtools/client/inspector/rules/test/browser_part2.ini, so maybe something changed in that suite, or in the way we shutdown tests?

I wonder if skipping the test would just move the intermittent to the previous test from the suite: browser_rules_user-agent-styles-uneditable.js

Comment 10

[Julian Descottes [:jdescottes]]

Also note that there are earlier failures than the one from the current backfill: https://treeherder.mozilla.org/jobs?repo=autoland&tochange=20c4f3149fb1cd465e1e16dab5c5b0d9cd824b9b&fromchange=082a4a75ee4cbcc88f00da5b2aa1425d3eace344&searchStr=Windows%2C10%2Cx64%2C2004%2CWebRender%2Cdebug%2CMochitests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Cwith%2Cfission%2Cenabled%2Ctest-windows10-64-2004-qr%2Fdebug-mochitest-devtools-chrome-spi-nw-fis-e10s%2Cdt1&selectedTaskRun=SAHqCXJySRKFgGSBsvqjPw.0

Starting more backfills, maybe we can find the regressing bug.

Comment 11

[Julian Descottes [:jdescottes]]

Retriggers at https://treeherder.mozilla.org/jobs?repo=autoland&tochange=20c4f3149fb1cd465e1e16dab5c5b0d9cd824b9b&fromchange=11ba6d0e581f209d0672d9613cd1da09cf321fa1&searchStr=Windows%2C10%2Cx64%2C2004%2CWebRender%2Cdebug%2CMochitests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Cwith%2Cfission%2Cenabled%2Ctest-windows10-64-2004-qr%2Fdebug-mochitest-devtools-chrome-spi-nw-fis-e10s%2Cdt1

They point at the following push: https://treeherder.mozilla.org/jobs?repo=autoland&searchStr=windows%2C10%2Cx64%2C2004%2Cwebrender%2Cdebug%2Cmochitests%2Cwith%2Cnetworking%2Con%2Csocket%2Cprocess%2Cwith%2Cfission%2Cenabled%2Ctest-windows10-64-2004-qr%2Fdebug-mochitest-devtools-chrome-spi-nw-fis-e10s%2Cdt1&revision=28829816a629b28125db3b4c65c5e22518e167e8

and therefore to Bug 1643586, which at least seems GC related.

Jan: do you have any advice to investigate this browser mochitest leak which started after Bug 1643586 ? I don't see anything peculiar about this test, if you have any pointer it could be helpful.

On a sidenote, it really seems related to this test. I tried skipping it and there is no failure anymore.

Comment 12

[Jan de Mooij [:jandem]]

Forwarding the request to jonco.

Maybe we could try bisecting the patches in that range?

Comment 13

[Julian Descottes [:jdescottes]]

I will try to bisect!
Clearing the ni? for bomsy, it's not related to the bug we initially suspected.

Comment 14

[Julian Descottes [:jdescottes]]

Not done yet, but patch 3 from the stack is fine https://hg.mozilla.org/integration/autoland/rev/8611c3ef5a77d9ea6a524f43294edca710a069e7

Comment 15

[Julian Descottes [:jdescottes]]

intermittent only starts with the last patch from the stack: https://hg.mozilla.org/integration/autoland/rev/28829816a629b28125db3b4c65c5e22518e167e8

The try push is at https://treeherder.mozilla.org/jobs?repo=try&revision=5c8906d7e3b2a00cfc27e18c3a8001b8c754703e. It's called "part5" because I forgot to update the push message, but it points to part 6. The real part 5 was at https://treeherder.mozilla.org/jobs?repo=try&revision=dbae1c6859550876ec259ff15d53a5c90a1f9719 and has no failure.

Comment 16

[Jon Coppeard (:jonco)]

(In reply to Julian Descottes [:jdescottes] from comment #15)

intermittent only starts with the last patch from the stack: https://hg.mozilla.org/integration/autoland/rev/28829816a629b28125db3b4c65c5e22518e167e8

Thanks for bisecting. That patch does seem to have triggered this.

Comment 17

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1643586

Comment 18

[Jon Coppeard (:jonco)]

Something about bug 1643586 seems to have triggered this to start failing in CI, but I can reproduce this failure locally before this landed. I'm using a linux optdebug build with MOZ_HEADLESS=1 and it's failing pretty much every time. I think it's sensitive to GC timing.

I can reproduce this at least as far back as bug 1737865.

Comment 19

[Julian Descottes [:jdescottes]]

Attachment: Bug 1758768 - [devtools] Skip browser_rules_user-property-reset.js on windows debug

Comment 20

[Julian Descottes [:jdescottes]]

Thanks for the investigation :jonco. Let's skip this on windows debug for now.

Comment 21

[Julian Descottes [:jdescottes]]

Filed Bug 1763787 for the follow up investigation.

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6070125c444e
[devtools] Skip browser_rules_user-property-reset.js on windows debug r=ochameau

Comment 23

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/6070125c444e

Comment 24

[Intermittent Failures Robot]

22 failures in 2922 pushes (0.008 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 8
• autoland: 14

Platform and build breakdown:

• windows10-64-2004-qr: 22
  • debug: 22

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1758768&startday=2022-04-04&endday=2022-04-10&tree=all

Comment 25

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jdescottes, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.

For more information, please visit auto_nag documentation.

Comment 26

[Julian Descottes [:jdescottes]]

Comment on attachment 9271432 [details]
Bug 1758768 - [devtools] Skip browser_rules_user-property-reset.js on windows debug

Beta/Release Uplift Approval Request

• User impact if declined: skip test to avoid intermittent failures
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky):
• String changes made/needed:

Comment 27

[Dianna Smith [:diannaS]]

https://hg.mozilla.org/releases/mozilla-beta/rev/58a3267ff572

Comment 28

[Dianna Smith [:diannaS]]

Comment on attachment 9271432 [details]
Bug 1758768 - [devtools] Skip browser_rules_user-property-reset.js on windows debug

Approved for 100.0b5