Closed Bug 1758778 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 33135 - Deduplicate browser setup logic for Android Chrome products

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox100 fixed)

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33135 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33135
Details from upstream follow.

Jonathan Lee <jonathanjlee@google.com> wrote:

Deduplicate browser setup logic for Android Chrome products

This change consolidates the essentially identical browser setups for chrome_android, android_webview, and android_weblayer.

This change also sets a default package name for webview/weblayer, which is currently done only for chrome_android:
https://github.com/web-platform-tests/wpt/blob/merge_pr_33129/tools/wpt/run.py#L406-L408

Currently, if wpt run is run for webview/weblayer without --package-name or --browser-version, browser_version will be missing from the final wptreport, which is required by wpt.fyi.

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ec63835b1775 [wpt PR 33135] - Deduplicate browser setup logic for Android Chrome products, a=testonly
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/05d2981a1ef6 [wpt PR 33135] - Deduplicate browser setup logic for Android Chrome products, a=testonly

https://hg.mozilla.org/mozilla-central/rev/05d2981a1ef6

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.