Closed Bug 1758809 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 33141 - Fire popstate for navigations intercepted by appHistory.transitionWhile()

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox100 fixed)

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33141 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33141
Details from upstream follow.

Nate Chapin <japhet@chromium.org> wrote:

Fire popstate for navigations intercepted by appHistory.transitionWhile()

This involves moving the logic for firing popstate from
FrameLoader::DidFinishSameDocumentNavigation (which is only fired for
fragment navigations), to DocumentLoader::UpdateForSameDocumentNavigaiton
(which is called for all same-document navigations).

Now that FrameLoader::DidFinishSameDocumentNavigation only handles
scrolling behavior (scroll restore and fragment processing), rename it
to ProcessScrollForSameDocumentNavigation.

Change-Id: I103cdf7fb7407bc8c35f13133cd8dfec1aab5421

Reviewed-on: https://chromium-review.googlesource.com/3514480
WPT-Export-Revision: 359be5cd35c363f0a7cb6aec248c5ee294e16735

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/app-history/ordering-and-transition/currentchange-before-popsate-transitionWhile.html
AppHistoryCurrentChangeEvent fires for appHistory.back() and appHistory.forward(): FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b3840a11cbcd [wpt PR 33141] - Fire popstate for navigations intercepted by appHistory.transitionWhile(), a=testonly https://hg.mozilla.org/integration/autoland/rev/f7f58fffca8e [wpt PR 33141] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c5fac8067682 [wpt PR 33141] - Fire popstate for navigations intercepted by appHistory.transitionWhile(), a=testonly https://hg.mozilla.org/integration/autoland/rev/de89c8d96e11 [wpt PR 33141] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/c5fac8067682
https://hg.mozilla.org/mozilla-central/rev/de89c8d96e11

Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.