Closed Bug 1758823 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 33146 - [tables] Only include border-spacing if we've seen a non-collapsed row.

Categories

(Core :: Layout: Tables, task, P4)

Product:
Core
Component:
Layout: Tables
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
100 Branch
Tracking Flags:
Tracking Status
firefox100 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 33146 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/33146
Details from upstream follow.

Ian Kilpatrick <ikilpatrick@chromium.org> wrote:

[tables] Only include border-spacing if we've seen a non-collapsed row.

Previously we'd include border-spacing if we've seen any first row.
This is incorrect, (can can lead to a double spacing) if the first
row(s) are collapsed.

Change-Id: Iaa7b999bfb77a82779b7a1d6d290caf6edbc5e68
Reviewed-on: https://chromium-review.googlesource.com/3513609
WPT-Export-Revision: ef4bc37457fc31a0c3620277811458c690995498

Component: web-platform-tests → Layout: Tables
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

FAIL: 1

Chrome

FAIL: 1

Safari

FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-tables/visibility-collapse-border-spacing.html: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/16b120f1e43f
[wpt PR 33146] - [tables] Only include border-spacing if we've seen a non-collapsed row., a=testonly
https://hg.mozilla.org/integration/autoland/rev/e0d2dd6492ee
[wpt PR 33146] - Update wpt metadata, a=testonly
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/48cdfad757cc
[wpt PR 33146] - [tables] Only include border-spacing if we've seen a non-collapsed row., a=testonly
https://hg.mozilla.org/integration/autoland/rev/d3d356fb144c
[wpt PR 33146] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/48cdfad757cc
https://hg.mozilla.org/mozilla-central/rev/d3d356fb144c

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox100: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.