Improvements for js/xpconnect/tests/marionette/test_preloader_telemetry.py
Categories
(Core :: XPConnect, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
People
(Reporter: whimboo, Assigned: whimboo)
References
Details
(Whiteboard: [bidi-m3-mvp])
Attachments
(1 external file)
The test is currently broken when certain code is awaiting an observer notification. Hereby the Execute Script and not the Execute Async Script command of Marionette is called:
This means that the command actually returns immediately and not when the notification has actually been retrieved.
Further the existing asserts for hits and misses are not that helpful given that we compare booleans and not the numbers directly. As such I would suggest to use assertions like assertGreater and assertLess.
| Assignee | ||
Comment 1•4 years ago
|
||
This patch allows to correctly await observer notifications by
using the "Execute Async Command" of Marionette which doesn't
return immediately but when resolve() is called.
Further it improves the checks for hits and misses by comparing
numbers and not just booleans. This improves the failure output.
Updated•4 years ago
|
| Assignee | ||
Updated•4 years ago
|
Comment 3•4 years ago
|
||
| bugherder | ||
Description
•