1758961 - finalize new private browsing mode strings & icon

Status: RESOLVED FIXED

(Firefox :: Installer, enhancement, P3)

Description

[[e-mail] (:bhearsum)]

Some parts of our refreshed Private Browsing Entry Points work are not yet finalized. Specifically: the string we're using in Shortcut descriptions, and the Icon we're using for shortcuts. These things will be landed pref'ed off for now, but must be updated before we pref on or otherwise make them user visible in any way.

The string changes are included in a few revisions that have yet to land:
https://phabricator.services.mozilla.com/D138196
https://phabricator.services.mozilla.com/D138197
https://phabricator.services.mozilla.com/D140653

The icon used is referred to by index in https://searchfox.org/mozilla-central/rev/61c6b2ca66b8fc7d82a71d6f045871e5a8649cbb/toolkit/xre/nsNativeAppSupportWin.h#20, https://searchfox.org/mozilla-central/rev/61c6b2ca66b8fc7d82a71d6f045871e5a8649cbb/browser/components/BrowserContentHandler.jsm#44, and the yet-to-be-landed https://phabricator.services.mozilla.com/D138197. If we end up just replacing the existing icon (the purple mask) this probably doesn't need to be changed. If we add a new icon, these indexes will likely need updating.

Comment 1

[[e-mail] (:bhearsum)]

Attachment: Bug 1758961: update windows private browsing mode icon. r?RT!,nalexander!

These new icon files come from the PNG handed off from UX, which I then ran through a PNG -> ICO converter, and dropped any icon sizes that aren't also included in our firefox.ico. The ones that were kept are: 256x256, 48x48, 32x32, and 16x16.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/171b2d9264c2
update windows private browsing mode icon. r=RT,nalexander

Comment 3

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/171b2d9264c2

Comment 4

[[e-mail] (:bhearsum)]

Re-opening because we're still waiting on strings.

Comment 5

[[e-mail] (:bhearsum)]

Attachment: Bug 1758961: update private browsing shortcuts and descriptions with finalized, localized strings

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/95488b794fe2
update private browsing shortcuts and descriptions with finalized, localized strings r=mhowell

Comment 7

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/95488b794fe2

Comment 8

[Ciprian Georgiu, Desktop QA]

Hi Ben! We've verified the patches from this bug on latest Nightly 104.0a1 with Win 11 x64, Win 10 x64, Win 7 x64 and Win 8.1 x86. We're not sure about a couple of things that we've encountered, so we could use your help with this:

1. The tooltip for the PBM icon from taskbar is "Nightly Private Browsing", see https://prnt.sc/SujbCyluHuuf. This is expected per Romain's comment form Jira. However, the string changes into "Firefox Nightly (Private Browsing)" after clicking the PBM icon, and while hovering over the taskbar icon, see https://prnt.sc/QsXhDpe2ODK0.

Is this intended?

2. The PBM icon has an .Ink extension at the end of the string, this is can be noticed if hovering over the taskbar icon or in the Win Start Menu, see https://prnt.sc/d_YJG30uSeft. Note that, I've created the PBM shortcut with the ShellService.pinToTaskbar(true); snippet ran in the browser console, after previously changing the browser.privacySegmentation.enabled pref to true. I've only able to reproduce this issue on Win 11, so far.

Can you please take a look at the above?

Comment 9

[[e-mail] (:bhearsum)]

Thank you!

(In reply to Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA from comment #8)

Hi Ben! We've verified the patches from this bug on latest Nightly 104.0a1 with Win 11 x64, Win 10 x64, Win 7 x64 and Win 8.1 x86. We're not sure about a couple of things that we've encountered, so we could use your help with this:

1. The tooltip for the PBM icon from taskbar is "Nightly Private Browsing", see https://prnt.sc/SujbCyluHuuf. This is expected per Romain's comment form Jira. However, the string changes into "Firefox Nightly (Private Browsing)" after clicking the PBM icon, and while hovering over the taskbar icon, see https://prnt.sc/QsXhDpe2ODK0.

Is this intended?

It's undefined :). It turns out this is also the case for non-private Firefox. We have "Firefox" when it's not running, and "Mozilla Firefox" when it is (at least, if you're on certain pages like about:newtab -- if you're at an actual website it uses the page title, with the other string as a suffix).

At the very least we should probably remove the parenthesis from the second case. Romain, do you have an opinion here?

2. The PBM icon has an .Ink extension at the end of the string, this is can be noticed if hovering over the taskbar icon or in the Win Start Menu, see https://prnt.sc/d_YJG30uSeft. Note that, I've created the PBM shortcut with the ShellService.pinToTaskbar(true); snippet ran in the browser console, after previously changing the browser.privacySegmentation.enabled pref to true. I've only able to reproduce this issue on Win 11, so far.

Can you please take a look at the above?

I think I know what the issue here is -- it seems I'm double appending .lnk in at least one case. (I don't know why it shows up in the start menu only on Windows 11 though.) I'll get a fix for this ready.

Comment 10

[[e-mail] (:bhearsum)]

Attachment: Bug 1758961: fix .lnk.lnk names when creating shortcuts through ShellService.pinToTaskbar r?mhowell!

Comment 11

[Romain Testard [:RT]]

(In reply to [e-mail] (:bhearsum) from comment #9)

Thank you!

(In reply to Ciprian Georgiu [:ciprian_georgiu], Release Desktop QA from comment #8)

Hi Ben! We've verified the patches from this bug on latest Nightly 104.0a1 with Win 11 x64, Win 10 x64, Win 7 x64 and Win 8.1 x86. We're not sure about a couple of things that we've encountered, so we could use your help with this:

1. The tooltip for the PBM icon from taskbar is "Nightly Private Browsing", see https://prnt.sc/SujbCyluHuuf. This is expected per Romain's comment form Jira. However, the string changes into "Firefox Nightly (Private Browsing)" after clicking the PBM icon, and while hovering over the taskbar icon, see https://prnt.sc/QsXhDpe2ODK0.

Is this intended?

It's undefined :). It turns out this is also the case for non-private Firefox. We have "Firefox" when it's not running, and "Mozilla Firefox" when it is (at least, if you're on certain pages like about:newtab -- if you're at an actual website it uses the page title, with the other string as a suffix).

At the very least we should probably remove the parenthesis from the second case. Romain, do you have an opinion here?

I agree with removing parenthesis but would not block on this

Comment 12

[BugBot [:suhaib / :marco/ :calixte]]

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/723956bb762b
fix .lnk.lnk names when creating shortcuts through ShellService.pinToTaskbar r=mhowell

Comment 14

[[e-mail] (:bhearsum)]

Attachment: Bug 1758961: remove parenthesis from private browsing title strings to match new shortcut strings r?nalexander!

This is something that came up in QA on this bug -- an inconsistency between the hover text on a running Firefox's Private Browser shortcut, and the hover text when it was not running (but pinned), largely captured in https://bugzilla.mozilla.org/show_bug.cgi?id=1758961#c11

Comment 15

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/723956bb762b

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e7ac572f15d
remove parenthesis from private browsing title strings to match new shortcut strings r=nalexander,fluent-reviewers,flod

Comment 17

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/8e7ac572f15d

Comment 18

[Monica Chiorean]

Verified on Win7/Win8.1/Win10/Win11 using build 104.0a1(20220707093757) that:

• at hover while browser is closed following message is displayed "Nightly Private Browsing"
• at hover while browser is opened following message is displayed "Firefox Nightly Private Browsing".