Closed Bug 1758973 Opened 3 years ago Closed 3 years ago

Update DevTools's reselect library to 4.1.5

Categories

(DevTools :: Framework, enhancement)

enhancement

Tracking

(firefox100 fixed)

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: ochameau, Assigned: ochameau)

References

Details

Attachments

(1 file)

We would benefit from using a new option from reselect: memoizeOptions.resultEqualityCheck.
This would help replace debugger makeShallowQuery/Resource API with this new builtin mechanism of reselect.
This was added in version 4.1 whereas we are still using 3.0.1.

It looks like there is no particular failure happening on try:
https://treeherder.mozilla.org/jobs?repo=try&revision=db5943a09b0f08b14e6ab1a5cf4503d4d77bddef

Assignee: nobody → poirot.alex

In the previous DAMP run I pushed base and new revision in different times during the day. I either messed up by pushing a different base, or pushing at different time during the day has an impact (could it be that server have different loads??).

Here is a new DAMP run that highlights no difference:
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=5c231faa2be5223c2a3c4f215d8af1f4574195d0&originalSignature=3130994&newSignature=3130994&framework=12&originalRevision=bf34f6a2755c22f4de584edea56b2ff2af5a7e02&page=1&showOnlyConfident=1

Pushed by apoirot@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/04fa4361be7e [devtools] Upgrade DevTools's reselect to 4.1.5 r=nchevobbe
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: