Update DevTools's reselect library to 4.1.5
Categories
(DevTools :: Framework, enhancement)
Tracking
(firefox100 fixed)
Tracking | Status | |
---|---|---|
firefox100 | --- | fixed |
People
(Reporter: ochameau, Assigned: ochameau)
References
Details
Attachments
(1 file)
We would benefit from using a new option from reselect: memoizeOptions.resultEqualityCheck
.
This would help replace debugger makeShallowQuery/Resource API with this new builtin mechanism of reselect.
This was added in version 4.1 whereas we are still using 3.0.1.
Assignee | ||
Comment 1•3 years ago
|
||
Assignee | ||
Comment 2•3 years ago
|
||
It looks like there is no particular failure happening on try:
https://treeherder.mozilla.org/jobs?repo=try&revision=db5943a09b0f08b14e6ab1a5cf4503d4d77bddef
Assignee | ||
Comment 3•3 years ago
|
||
And here is a DAMP run (still pending while I write this comment):
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=74f69f8f565fdf478ce534de37d2e06a56ca2cf2&originalSignature=3130994&newSignature=3130994&framework=12&originalRevision=065b49ae5491fb0412200f3c1b64ca46181850af&page=1
Assignee | ||
Comment 4•3 years ago
•
|
||
In the previous DAMP run I pushed base and new revision in different times during the day. I either messed up by pushing a different base, or pushing at different time during the day has an impact (could it be that server have different loads??).
Here is a new DAMP run that highlights no difference:
https://treeherder.mozilla.org/perfherder/comparesubtest?originalProject=try&newProject=try&newRevision=5c231faa2be5223c2a3c4f215d8af1f4574195d0&originalSignature=3130994&newSignature=3130994&framework=12&originalRevision=bf34f6a2755c22f4de584edea56b2ff2af5a7e02&page=1&showOnlyConfident=1
Comment 6•3 years ago
|
||
bugherder |
Description
•