Closed
Bug 175900
Opened 22 years ago
Closed 22 years ago
read overrun in ldap resolve code
Categories
(Directory :: LDAP C SDK, defect, P2)
Tracking
(Not tracked)
RESOLVED
FIXED
5.12
People
(Reporter: blizzard, Assigned: mcs)
Details
(Whiteboard: [sg:branch])
Attachments
(1 file, 1 obsolete file)
2.62 KB,
patch
|
Details | Diff | Splinter Review |
nalin@redhat.com reported to me a read overrun in the ldap code. I'll attach
the patch in a moment. He says that he thinks that it's not used anymore so it
might not matter.
Reporter | ||
Comment 1•22 years ago
|
||
Assignee | ||
Comment 2•22 years ago
|
||
That code is not used. Still, I will review the patch soon. We do compile the
file, but all the code in getdxbyname.c is inside an #ifdef LDAP_DNS / #endif
block. The LDAP_DNS features are experimental and have never been compiled by
the mozilla Makefiles.
Assignee | ||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Whiteboard: tm511
Whiteboard: tm511 → tm511 [sg:branch]
Assignee | ||
Updated•22 years ago
|
Target Milestone: --- → 5.11
Assignee | ||
Updated•22 years ago
|
Whiteboard: tm511 [sg:branch] → [sg:branch]
Comment 4•22 years ago
|
||
blizzard, do you agree that this code is not used? If so, we can make this bug
public.
Assignee | ||
Comment 6•22 years ago
|
||
Mass move of several bugs to TM 5.12.
Target Milestone: 5.11 → 5.12
Assignee | ||
Comment 7•22 years ago
|
||
Comment on attachment 103650 [details] [diff] [review]
mozilla-1.0.1-dnsparse.patch
Patch looks OK, except the nsldapi_getdxbyname() already includes a call to
memset().
Attachment #103650 -
Flags: review+
Assignee | ||
Comment 8•22 years ago
|
||
same as original patch with redundant memset() call removed and one comment fix
(typo)
Attachment #103650 -
Attachment is obsolete: true
Assignee | ||
Comment 9•22 years ago
|
||
Fix committed to the trunk:
mozilla/directory/c-sdk/ldap/libraries/libldap/getdxbyname.c
new revision: 5.1; previous revision: 5.0
Fix 175900 - read overrun in ldap resolve code.
Note: this fixes code we do not compile right now.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•