Closed Bug 1759131 Opened 4 years ago Closed 4 years ago

TestInterfaceObservableArrayBinding.cpp:795:9: error: ForOfIterator is not a member of JS

Categories

(Core :: DOM: Bindings (WebIDL), defect)

defect

Tracking

()

RESOLVED DUPLICATE of bug 1759074

People

(Reporter: petr.sumbera, Unassigned)

References

(Regression)

Details

(Keywords: regression)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Firefox/91.0

Steps to reproduce:

Solaris build fails with:

 6:33.57 TestInterfaceObservableArrayBinding.cpp:795:9: error: ForOfIterator is not a member of JS
 6:33.57   795 |     JS::ForOfIterator iter(cx);
 6:33.57       |         ^~~~~~~~~~~~~
 6:33.58 TestInterfaceObservableArrayBinding.cpp:796:10: error: iter was not declared in this scope
 6:33.58   796 |     if (!iter.init(args[0], JS::ForOfIterator::AllowNonIterable)) {
 6:33.58       |          ^~~~
 6:33.58 TestInterfaceObservableArrayBinding.cpp:796:33: error: JS::ForOfIterator has not been declared
 6:33.58   796 |     if (!iter.init(args[0], JS::ForOfIterator::AllowNonIterable)) {
 6:33.58       |                                 ^~~~~~~~~~~~~
 6:33.59 TestInterfaceObservableArrayBinding.cpp:799:10: error: iter was not declared in this scope
 6:33.59   799 |     if (!iter.valueIsIterable()) {
 6:33.59       |          ^~~~
...

The first bad revision is:
changeset: 610269:bd45b431c375
user: Edgar Chen <echen@mozilla.com>
date: Thu Mar 10 14:44:28 2022 -0800
description:
Bug 1683281 - Part 5: Generate binding code for ObservableArray type; r=peterv

Keywords: regression
Regressed by: 1683281
Status: UNCONFIRMED → RESOLVED
Closed: 4 years ago
Component: Untriaged → DOM: Bindings (WebIDL)
Product: Firefox → Core
Resolution: --- → DUPLICATE

Could you try if the patch in bug 1759074 fixes the build failures? Thanks!

Flags: needinfo?(petr.sumbera)

(In reply to Edgar Chen [:edgar] from comment #2)

Could you try if the patch in bug 1759074 fixes the build failures? Thanks!

I can build Firefox with the patch again.

Flags: needinfo?(petr.sumbera)
Has Regression Range: --- → yes
You need to log in before you can comment on or make changes to this bug.