175920 - Add null check to prevent JS errors in getContentFrameURI() at startup

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect)

Description

[HJ]

Several mozdev projects are using a modified version of function
getReferrer(doc) in contentAreaUtils.js This function calls getContentFrameURI()
in the same file but this produces a JavaScript error on the JS console at
startup. This happens at startup only, because |aFocusedWindow| is still null.
The modified function is called from an overlay file of one of the projects.
MultiZilla is one of the projects that suffers from this 'bug'.

callion has a patch to fix this problem so I'll assign this bug to him.

Comment 1

[Christopher Aillon (sabbatical, not receiving bugmail)]

Attachment: Fix

Null window cannot be in the content area.

Comment 2

[HJ]

Comment on attachment 103677 [details] [diff] [review]
Fix

That patch looks fine to me, and it also works. Thanks for the quick fix.

Comment 3

[Brian Ryner (not reading)]

Comment on attachment 103677 [details] [diff] [review]
Fix

sr=bryner

Comment 4

[HJ]

Comment on attachment 103677 [details] [diff] [review]
Fix

r=hj (forgot to add it)

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Comment on attachment 103677 [details] [diff] [review]
Fix

a=roc+moz for trunk

Comment 6

[Christopher Blizzard (:blizzard)]

This needs to get checked in.  It's been approved and is on the 1.2 list.

Comment 7

[Christopher Aillon (sabbatical, not receiving bugmail)]

It already did get landed right after it got approved.  Thought I marked this
fixed....