[wpt-sync] Sync PR 33154 - Collecting all named grid areas in grid template shorthand
Categories
(Core :: Layout: Grid, task, P4)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox100 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Sync web-platform-tests PR 33154 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/33154
Details from upstream follow.
Ana SollanoKim <ansollan@microsoft.com> wrote:
Collecting all named grid areas in grid template shorthand
In this CL a bug related to grid areas shorthand serialization is fixed.
Previously, we just returned the first key of a named area in a given
row, thus losing named areas. This is fixed by collecting and appending
grid areas in a given row and column.A test case in grid-template-shorthand-areas-valid.html is added to
validate the behavior.Bug: 1303968
Change-Id: I7e91ba036250a0740e88a3f4e6fc6bbc95871d95
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3514442
Reviewed-by: Daniel Libby \<dlibby@microsoft.com>
Commit-Queue: Ana Sollano Kim \<ansollan@microsoft.com>
Cr-Commit-Position: refs/heads/main@{#979954}
|
Assignee | |
Updated•2 years ago
|
|
|
Assignee | |
Comment 1•2 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=0d501f1231202c8c9a5138e568aa5da0afa0ab9c
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7b800e3349ad [wpt PR 33154] - Collecting all named grid areas in grid template shorthand, a=testonly
|
|
Assignee | |
Comment 3•2 years ago
|
||
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/093589347bd2 [wpt PR 33154] - Collecting all named grid areas in grid template shorthand, a=testonly
|
||
Comment 5•2 years ago
|
||
| bugherder | ||
Description
•