1759281 - Bustage on WasmInstance.h e.g: error: no member named 'pendingException_' in 'Instance' when Gecko 100 merges to Beta on 2022-04-04

Status: VERIFIED FIXED

(Core :: JavaScript: WebAssembly, defect, P2)

Description

[Natalia Csoregi [:nataliaCs]]

• Central-as-beta
• How to run these simulations
• Failure log

[task 2022-03-12T11:58:45.867Z] In file included from /builds/worker/checkouts/gecko/js/src/wasm/WasmTlsData.h:27:
[task 2022-03-12T11:58:45.867Z] /builds/worker/checkouts/gecko/js/src/wasm/WasmInstance.h:240:12: error: no member named 'pendingException_' in 'Instance'
[task 2022-03-12T11:58:45.867Z]     return offsetof(Instance, pendingException_);
[task 2022-03-12T11:58:45.867Z]            ^                  ~~~~~~~~~~~~~~~~~

• Failure log

[task 2022-03-12T11:55:20.433Z] /builds/worker/workspace/sm-package/mozjs-100.0.0/js/src/wasm/WasmInstance.h:240:31: error: 'class js::wasm::Instance' has no member named 'pendingException_'; did you mean 'setPendingException'?
[task 2022-03-12T11:55:20.433Z]      return offsetof(Instance, pendingException_);
[task 2022-03-12T11:55:20.433Z]                           

And many other failures within the failure logs, all related to WasmInstance.h
Ryan, these might be caused by Bug 1753692.
Can you take a look please? Thank you.

Comment 1

[Ryan Hunt [:rhunt]]

I have a patch for this. I'm also filing bug 1759542 to try to prevent this from happening in the future.

Comment 2

[Ryan Hunt [:rhunt]]

Attachment: Bug 1759281 - wasm: Fix build bustage. r?lth

Rebasing left an unused setPendingException method that
somehow didn't cause an error, until it causes compile
errors without exception handling.

There's also offsetof methods that need conditional
compilation.

Comment 3

[Ryan Hunt [:rhunt]]

https://treeherder.mozilla.org/jobs?repo=try&revision=84e33d00b7c6b4aad4a6844bf63c934efbb1c983

Comment 4

[Cristina Cozmuta (:CrissCozmuta)]

The patch seems to be working on today's beta sim.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a571b126118
wasm: Fix build bustage. r=lth

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/9a571b126118

Comment 7

[Norisz Fay [:noriszfay]]

Verified fixed as of today's central as beta-sim