1759501 - Turn on clang thread-safety analysis

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, enhancement)

Description

[Randell Jesup [:jesup] (needinfo me)]

Bug 1207753 is landing very soon; this is to turn on thread-safety analysis by default. As part of this landing, we'll be sending email to dev.platform requiring people to resolve all thread-safety warnings to land code (and to add thread-safety annotations to any new Mutexes and Monitors).

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: Bug 1759501: turn on clang thread-safety checking r=#firefox-build-system-reviewers

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox Build System::Source Code Analysis' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/64ec4c736bb4
turn on clang thread-safety checking r=firefox-build-system-reviewers,mhentges

Comment 4

[Sandor Molnar[:smolnar]]

Backed out changeset 64ec4c736bb4 (bug 1759501) for causing build bustages in dom/base/BodyStream.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/73c7e32cb77b953cda162a92f291ece2e71a1b5b

Push with failures

Failure log

INFO -  In file included from Unified_cpp_dom_base0.cpp:74:
[task 2022-03-17T23:42:54.816Z] 23:42:54    ERROR -  /builds/worker/checkouts/gecko/dom/base/BodyStream.cpp:534:21: error: releasing mutex 'mMutex' that was not held [-Werror,-Wthread-safety-analysis]
[task 2022-03-17T23:42:54.816Z] 23:42:54     INFO -      MutexAutoUnlock unlock(mMutex);
[task 2022-03-17T23:42:54.816Z] 23:42:54     INFO -                      ^
[task 2022-03-17T23:42:54.816Z] 23:42:54    ERROR -  /builds/worker/checkouts/gecko/dom/base/BodyStream.cpp:763:19: error: releasing mutex 'mMutex' that was not held [-Werror,-Wthread-safety-analysis]
[task 2022-03-17T23:42:54.816Z] 23:42:54     INFO -    MutexAutoUnlock unlock(mMutex);

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5da7ce787cba
turn on clang thread-safety checking r=firefox-build-system-reviewers,mhentges,andi

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/5da7ce787cba

Comment 7

[Alessandro Castellani [:aleca]]

This busted our Linux and macOS builds: https://treeherder.mozilla.org/jobs?repo=comm-central&revision=4e025c3a344db820d3515ed8263ee385570d4175
Any pointers on how to fix it, if this needs porting or is our code the culprit?