Closed Bug 1759563 Opened 2 years ago Closed 2 years ago

Add SerializedComplexity to track the complexity of serializing nsIInputStreams

Categories

(Core :: XPCOM, enhancement, P3)

Product:
Core
Component:
XPCOM
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
102 Branch
Tracking Flags:
Tracking Status
firefox102 --- fixed

People

(Reporter: nika, Assigned: nika)

References

Details

Attachments

(1 file)

Bug 1759563 - Add SerializedComplexity to limit the complexity of serialized IPCStream instances, r=asuth!
48 bytes, text/x-phabricator-request
Details | Review

This will improve the efficiency of serializing large data pipes, which in bad cases can end up serializing very small amounts of data in individual pipes over IPC, and acts as a compliment to the existing logic for limiting serialized message sizes. It is also necessary for the changes in bug 1754004, which require the ability to include FileDescriptor inline in the message, which could blow out our FileDescriptor count limits if pipe creation was
unlimited.

In some tests, this change reduces the number of pipes required to serialize a nsIInputStream from over 5000 to 1.

This will improve the efficiency of serializing large data pipes, which in bad
cases can end up serializing very small amounts of data in individual pipes
over IPC, and acts as a compliment to the existing logic for limiting
serialized message sizes. It is also necessary for the changes in bug 1754004,
which require the ability to include FileDescriptor inline in the message,
which could blow out our FileDescriptor count limits if pipe creation was
unlimited.

In some tests, this change reduces the number of pipes required to serialize a
nsIInputStream from over 5000 to 1.

Depends on D141035

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:nika, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit auto_nag documentation.

Flags: needinfo?(nika)
Flags: needinfo?(bugmail)

Waiting on other patches in the stack

Flags: needinfo?(nika)
Flags: needinfo?(bugmail)
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6c102f8e3d4a
Add SerializedComplexity to limit the complexity of serialized IPCStream instances, r=asuth,necko-reviewers,dragana
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e731c9fa7444
Add SerializedComplexity to limit the complexity of serialized IPCStream instances, r=asuth,necko-reviewers,dragana

https://hg.mozilla.org/mozilla-central/rev/e731c9fa7444

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch

Backed out as they were linked to the backed out Bug 1754004

Backout link

Status: RESOLVED → REOPENED
status-firefox102: fixed → ---
Flags: needinfo?(nika)
Resolution: FIXED → ---
Target Milestone: 102 Branch → ---
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cdd271a5af42
Add SerializedComplexity to limit the complexity of serialized IPCStream instances, r=asuth,necko-reviewers,dragana
Flags: needinfo?(nika)
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f820e0f209ff
Add SerializedComplexity to limit the complexity of serialized IPCStream instances, r=asuth,necko-reviewers,dragana
Pushed by nlayzell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7b0d28d3162f
Add SerializedComplexity to limit the complexity of serialized IPCStream instances, r=asuth,necko-reviewers,dragana
Flags: needinfo?(nika)

https://hg.mozilla.org/mozilla-central/rev/7b0d28d3162f

Status: REOPENED → RESOLVED
Closed: 2 years ago → 2 years ago
status-firefox102: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 102 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: