Closed Bug 1759578 Opened 9 months ago Closed 8 months ago

BMB_viewBookmarksSidebar is missing "key" attribute so lacks accel text

Categories

(Firefox :: Bookmarks & History, defect, P3)

Desktop
Unspecified
defect

Tracking

()

RESOLVED FIXED
100 Branch
Tracking Status
firefox100 --- fixed

People

(Reporter: aminomancer, Assigned: aminomancer)

Details

Attachments

(1 file)

So BMB_bookmarksShowAllTop ("Manage bookmarks") has a "key" attribute so it shows Accel+Shift+O. But BMB_viewBookmarksSidebar ("View bookmarks sidebar") does not. So it should show Accel+B for consistency and usability but that's missing.

Btw the equivalent menu item menu_bookmarksSidebar does have the "key" attribute, so another reason to add it to BMB_viewBookmarksSidebar

Same with sidebar-switcher-bookmarks

Assignee: nobody → shmediaproductions
Status: NEW → ASSIGNED

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit auto_nag documentation.

Flags: needinfo?(mak)
Severity: -- → S4
Flags: needinfo?(mak)
Priority: -- → P3
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/d176b078320f
Add accel text to bookmarks sidebar menu item. r=mak
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 100 Branch
You need to log in before you can comment on or make changes to this bug.