1759579 - Improve performance of cookiesAllowedForDomainOrSubDomain check in Sanitizer.jsm

Status: RESOLVED FIXED

(Toolkit :: Data Sanitization, enhancement, P2)

Description

[Emma Zühlcke [:emz]]

We're landing a simple performance optimization in Bug 1755190 by only querying "cookie" permissions from the permission manager, rather than all permissions.

This is bug is for optimizing this method further. Here are a few improvements we could make:

1. Check if cookiesAllowedForDomainOrSubDomain gets passed duplicate principals. We can already do deduplication in the PrincipalsCollector
2. Only get array of permissions via Services.perms.getByTypePrefix once from the permission manager and reuse the array in subsequent checks for the other principals.
3. (Refactor to iterative rather than recursive approach)

Comment 1

[Hannah Peuckmann]

Attachment: Bug 1759579 - Improve performace of (sub)domain cookie permission check in sanitizeOnShutdown. r=pbz!

Comment 2

[Hannah Peuckmann]

Attachment: Bug 1759579 - Remove recursion from (sub)domain cookie check. r=pbz!

Depends on D141496

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a54f17b63dbc
Improve performace of (sub)domain cookie permission check in sanitizeOnShutdown. r=pbz
https://hg.mozilla.org/integration/autoland/rev/d60011405047
Remove recursion from (sub)domain cookie check. r=pbz

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a54f17b63dbc
https://hg.mozilla.org/mozilla-central/rev/d60011405047