1759580 - Rename references to TlsData

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, task, P3)

Description

[Ryan Hunt [:rhunt] (on leave until early May)]

Now that TlsData has been merged into Instance, we should rename all remaining references to TlsData.

Comment 1

[Ryan Hunt [:rhunt] (on leave until early May)]

I think the best way to do this will be piecemeal and over time. I'm uploading some starting patches that mostly do types and methods, which are the easiest to find and replace. After that will need to be fields and variables, which are more complicated.

Comment 2

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1759580 - wasm: Rename types and methods of FrameWithTls. r?lth

Completely mechanical, no functional change.

Comment 3

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1759580 - wasm: Rename GetNearestEffectiveTls. r?lth

Completely mechanical, no functional changes.

Depends on D141153

Comment 4

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1759580 - wasm: Rename FuncImportTls, TableTls, and fields. r?lth

Depends on D141154

Comment 5

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1759580 - wasm: Rename switchToWasmTlsRealm() and loadWasmPinnedRegsFromTls(). r?lth

Depends on D141155

Comment 6

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1759580 - wasm: Rename JitActivation::wasmExitTls(). r?lth

Depends on D141156

Comment 7

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1759580 - wasm: Rename WasmFrameIter::instance_ and instance(). r?lth

Depends on D141157

Comment 8

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1759580 - wasm: Rename WasmTlsReg to InstanceReg. r?lth

Mechanical, no functional change.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/90319e554ec0
wasm: Rename WasmTlsReg to InstanceReg. r=lth
https://hg.mozilla.org/integration/autoland/rev/980655a05602
wasm: Rename types and methods of FrameWithTls. r=lth
https://hg.mozilla.org/integration/autoland/rev/ab64e2573ce5
wasm: Rename GetNearestEffectiveTls. r=lth
https://hg.mozilla.org/integration/autoland/rev/74e14ae6bb64
wasm: Rename FuncImportTls, TableTls, and fields. r=lth
https://hg.mozilla.org/integration/autoland/rev/927c2910dd1a
wasm: Rename switchToWasmTlsRealm() and loadWasmPinnedRegsFromTls(). r=lth
https://hg.mozilla.org/integration/autoland/rev/cfcd3cb6891d
wasm: Rename JitActivation::wasmExitTls(). r=lth
https://hg.mozilla.org/integration/autoland/rev/6f30be8d9fe7
wasm: Rename WasmFrameIter::instance_ and instance(). r=lth

Comment 10

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/90319e554ec0
https://hg.mozilla.org/mozilla-central/rev/980655a05602
https://hg.mozilla.org/mozilla-central/rev/ab64e2573ce5
https://hg.mozilla.org/mozilla-central/rev/74e14ae6bb64
https://hg.mozilla.org/mozilla-central/rev/927c2910dd1a
https://hg.mozilla.org/mozilla-central/rev/cfcd3cb6891d
https://hg.mozilla.org/mozilla-central/rev/6f30be8d9fe7

Comment 11

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1759580 - wasm: Fix cranelift interface for recent changes. r?lth

• Rename references of tls to instance
• Fix instance call protocol to use the vmctx as the instance pointer
  instead of loading an instance pointer from it
• Fix offsetof calculations to use the encapsulated methods on Instance

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5b0bc72eb89
wasm: Fix cranelift interface for recent changes. r=lth

Comment 13

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b5b0bc72eb89

Comment 14

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1759580 - wasm: Rename references to tls in js/src/jit. r?lth

Comment 15

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1759580 - wasm: Rename references to tls in baseline compile. r?lth

Depends on D145271

Comment 16

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1759580 - wasm: Rename reference to tls in WasmStubs.cpp. r?lth

Depends on D145272

Comment 17

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1759580 - wasm: Rename slots on JSFunction. r?lth

Depends on D145273

Comment 18

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1759580 - wasm: Rename WasmTlsData.h header. r?lth

Depends on D145274

Comment 19

[Ryan Hunt [:rhunt] (on leave until early May)]

Attachment: Bug 1759580 - wasm: Rename misc tls references. r?lth

Depends on D145275

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d5848a52ccd8
wasm: Rename references to tls in js/src/jit. r=lth
https://hg.mozilla.org/integration/autoland/rev/f761a171c009
wasm: Rename references to tls in baseline compile. r=lth
https://hg.mozilla.org/integration/autoland/rev/015e7fd96694
wasm: Rename reference to tls in WasmStubs.cpp. r=lth
https://hg.mozilla.org/integration/autoland/rev/769bfc4f4dca
wasm: Rename slots on JSFunction. r=lth
https://hg.mozilla.org/integration/autoland/rev/c234e682cce6
wasm: Rename WasmTlsData.h header. r=lth
https://hg.mozilla.org/integration/autoland/rev/c0965740a2b1
wasm: Rename misc tls references. r=lth

Comment 21

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d5848a52ccd8
https://hg.mozilla.org/mozilla-central/rev/f761a171c009
https://hg.mozilla.org/mozilla-central/rev/015e7fd96694
https://hg.mozilla.org/mozilla-central/rev/769bfc4f4dca
https://hg.mozilla.org/mozilla-central/rev/c234e682cce6
https://hg.mozilla.org/mozilla-central/rev/c0965740a2b1

Comment 22

[Ryan Hunt [:rhunt] (on leave until early May)]

This is now done.