1759581 - Simplify RefreshDriverVsyncObserver logic after bug 1755006

Status: RESOLVED FIXED

(Core :: Layout, task)

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1759581 - Return early if RefreshDriverVsyncObserver is notified after its timer has gone away. r=smaug

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1759581 - Move some code around. r=smaug

Depends on D141010

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1759581 - Leave mLastTickStart/End untouched until the end of the function, and also reuse the tickStart timestamp instead of calling TimeStamp::Now() another time. r=smaug

Depends on D141011

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1759581 - Move more code around. r=smaug

Depends on D141012

Comment 5

[Markus Stange [:mstange]]

Attachment: Bug 1759581 - Use different timeForOutsideTick variables in the different paths. r=smaug

Depends on D141013

Comment 6

[Markus Stange [:mstange]]

Attachment: Bug 1759581 - Leave rate as a TimeDuration and don't convert it to milliseconds. r=smaug

Depends on D141014

Comment 7

[Markus Stange [:mstange]]

Attachment: Bug 1759581 - Use clamped(). r=smaug

Depends on D141015

Comment 8

[Markus Stange [:mstange]]

Attachment: WIP: Bug 1759581 - Behavior change: Use tickStart as the reference timestamp when computing mSuspendVsyncPriorityTicksUntil for the "give non-vsync tasks more time" case.

tickStart is later than aVsyncTimeStamp if the tick was delayed by other work in the event loop.

I think this might have been what was intended. It makes the math simpler to reason about, at least.

Depends on D141016

Comment 9

[Markus Stange [:mstange]]

Attachment: WIP: Bug 1759581 - Simplify math.

Depends on D141017

Comment 10

[Markus Stange [:mstange]]

Attachment: WIP: Bug 1759581 - Pull "tickEnd +" into the clamped().

Depends on D141018

Comment 11

[Markus Stange [:mstange]]

Attachment: WIP: Bug 1759581 - Introduce a nonVsyncWorkDurationSinceLastTick variable.

Depends on D141019

Comment 12

[Markus Stange [:mstange]]

Attachment: Bug 1759581 - Move tickEnd - tickStart into the clamped(). This is a slight behavior change because the zero minimum and 4 vsync maximum will now be enforced on the entire frame budget, not just on the non-vsync part of the frame. r=smaug

Depends on D141016

Comment 13

[Markus Stange [:mstange]]

Attachment: Bug 1759581 - Simplify math. r=smaug

Depends on D142731

Comment 14

[Markus Stange [:mstange]]

Attachment: Bug 1759581 - Introduce a fullFrameDuration variable and remove fullFrameBudget variable. r=smaug

Depends on D142732

Comment 15

[Markus Stange [:mstange]]

Attachment: Bug 1759581 - Introduce more TimeStamp variables and make the nested tick handling more explicit. r=smaug

Unlike https://phabricator.services.mozilla.com/D141012, this doesn't change behavior.

Depends on D141011

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d47889be4532
Return early if RefreshDriverVsyncObserver is notified after its timer has gone away. r=smaug
https://hg.mozilla.org/integration/autoland/rev/f0e39c532cc5
Move some code around. r=smaug
https://hg.mozilla.org/integration/autoland/rev/ef57a9573466
Introduce more TimeStamp variables and make the nested tick handling more explicit. r=smaug
https://hg.mozilla.org/integration/autoland/rev/7d8d1de620b9
Move more code around. r=smaug
https://hg.mozilla.org/integration/autoland/rev/fe2f9ffe44bd
Use different timeForOutsideTick variables in the different paths. r=smaug
https://hg.mozilla.org/integration/autoland/rev/4e9b215ae20a
Leave rate as a TimeDuration and don't convert it to milliseconds. r=smaug
https://hg.mozilla.org/integration/autoland/rev/77eec1011469
Use clamped(). r=smaug

Comment 17

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/d47889be4532
https://hg.mozilla.org/mozilla-central/rev/f0e39c532cc5
https://hg.mozilla.org/mozilla-central/rev/ef57a9573466
https://hg.mozilla.org/mozilla-central/rev/7d8d1de620b9
https://hg.mozilla.org/mozilla-central/rev/fe2f9ffe44bd
https://hg.mozilla.org/mozilla-central/rev/4e9b215ae20a
https://hg.mozilla.org/mozilla-central/rev/77eec1011469